Improve and enhance the web service #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanio
added
release/update
Fix all references for hostname to address in the configuration to merge on the standard of address for binding the server.
Add filters for slog-gin which ignores /alive and /healthz endpoints for standard access logging. Additionally, don't log 404 and 401 messages as these don't provide significant value.
Add an initial middleware function, and map the default handler, for Prometheus into the web service, allowing monitoring of the requests made against the service and the latency.
Refactor the configuration processing to conbine the cobra and viper code, setting the command-line flags alongside the configuration file and environment settings. This should make it easier to build and manage the two components for configuration the application together.
Split the testing and the code analysis tasks into separate groups and allow the build take to take priority over the code analysis, allowing for faster local development.
jonathanio
force-pushed
the
improve-web-service
branch
from
42e1ba0 to
48a1b49
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 16.44% 15.10% -1.35%
==========================================
Files 14 13 -1
Lines 304 331 +27
==========================================
Hits 50 50
- Misses 254 281 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a number of enhancements to the web services to make it easier to work with and develop, including:
/alive,/healthz, and/metrics, as there is no need to report on these for backend analysis.countanddurationmetrics for Prometheus, and add the/metricsendpoints to report those.cobraandviperconfigurations into theinit()function for eachcmdso that configuration files, environments, and command-line arguments are combined into single blocks, and changes in one are not lost from another.Checklist
Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:
release/...,type/..., andchanges/...labels, as needed, to this pull request