Skip to content

Commit

Permalink
fix(core): Fix continueOnFail for expression error in Set (#6939)
Browse files Browse the repository at this point in the history
* fix(core): Fix `continueOnFail` for expression error in Set

* Add story
  • Loading branch information
ivov authored and netroy committed Aug 17, 2023
1 parent e45461a commit 2a3937f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/core/src/NodeExecuteFunctions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,8 @@ export function getNodeParameter(
);
cleanupParameterData(returnData);
} catch (e) {
if (e instanceof ExpressionError && node.continueOnFail && node.name === 'Set') {
if (e instanceof ExpressionError && node.continueOnFail && node.type === 'n8n-nodes-base.set') {
// https://linear.app/n8n/issue/PAY-684
returnData = [{ name: undefined, value: undefined }];
} else {
if (e.context) e.context.parameter = parameterName;
Expand Down

0 comments on commit 2a3937f

Please sign in to comment.