Skip to content

Commit

Permalink
fix(node): Freshdesk - fix issue when getAll operation requires non e…
Browse files Browse the repository at this point in the history
…xistent options
  • Loading branch information
michael-radency authored Aug 19, 2022
1 parent 43e054f commit 329fe95
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 0 additions & 2 deletions packages/nodes-base/nodes/Freshdesk/Freshdesk.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,6 @@ export class Freshdesk implements INodeType {
displayName: 'Priority',
name: 'priority',
type: 'options',
required: true,
options: [
{
name: 'Low',
Expand Down Expand Up @@ -759,7 +758,6 @@ export class Freshdesk implements INodeType {
displayName: 'Status',
name: 'status',
type: 'options',
required: true,
options: [
{
name: 'Open',
Expand Down
8 changes: 3 additions & 5 deletions packages/nodes-base/nodes/Freshdesk/GenericFunctions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { OptionsWithUri } from 'request';

import { BINARY_ENCODING, IExecuteFunctions, ILoadOptionsFunctions } from 'n8n-core';

import { IDataObject, NodeApiError, NodeOperationError } from 'n8n-workflow';
import { IDataObject, NodeApiError } from 'n8n-workflow';

export async function freshdeskApiRequest(
this: IExecuteFunctions | ILoadOptionsFunctions,
Expand All @@ -13,8 +13,7 @@ export async function freshdeskApiRequest(
query: IDataObject = {},
uri?: string,
option: IDataObject = {},
// tslint:disable-next-line:no-any
): Promise<any> {
) {
const credentials = await this.getCredentials('freshdeskApi');

const apiKey = `${credentials.apiKey}:X`;
Expand Down Expand Up @@ -53,8 +52,7 @@ export async function freshdeskApiRequestAllItems(
// tslint:disable-next-line:no-any
body: any = {},
query: IDataObject = {},
// tslint:disable-next-line:no-any
): Promise<any> {
) {
const returnData: IDataObject[] = [];

let responseData;
Expand Down

0 comments on commit 329fe95

Please sign in to comment.