⏰ Add optional LDAP connection timeout

n8n-io · Oct 13, 2023 · 3c61445 · 3c61445
1 parent f560a5e
commit 3c61445
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/packages/nodes-base/credentials/Ldap.credentials.ts b/packages/nodes-base/credentials/Ldap.credentials.ts
@@ -88,5 +88,12 @@ export class Ldap implements ICredentialType {
 			type: 'string',
 			default: '',
 		},
+		{
+			displayName: 'Timeout',
+			description: 'Optional connection timeout in seconds',
+			name: 'timeout',
+			type: 'number',
+			default: 300,
+		},
 	];
 }
diff --git a/packages/nodes-base/nodes/Ldap/Helpers.ts b/packages/nodes-base/nodes/Ldap/Helpers.ts
@@ -39,6 +39,11 @@ export async function createLdapClient(
 		}
 	}
 
+	if (credentials.timeout) {
+		// Convert seconds to milliseconds
+		ldapOptions.timeout = (credentials.timeout as number) * 1000;
+	}
+
 	if (nodeDebug) {
 		Logger.info(
 			`[${nodeType} | ${nodeName}] - LDAP Options: ${JSON.stringify(ldapOptions, null, 2)}`,