refactor: Remove unused lint directives (no-changelog) (#9842)

n8n-io · Jun 24, 2024 · 44ea4c7 · 44ea4c7
1 parent 16d3083
commit 44ea4c7
Show file tree

Hide file tree

Showing 92 changed files with 85 additions and 138 deletions.
diff --git a/cypress/e2e/13-pinning.cy.ts b/cypress/e2e/13-pinning.cy.ts
@@ -165,7 +165,7 @@ describe('Data pinning', () => {
 		ndv.actions.close();
 
 		workflowPage.actions.addNodeToCanvas(EDIT_FIELDS_SET_NODE_NAME, true, true);
-		// eslint-disable-next-line @typescript-eslint/no-use-before-define
+
 		setExpressionOnStringValueInSet(`{{ $('${HTTP_REQUEST_NODE_NAME}').item`);
 
 		const output = '[Object: {"json": {"http": 123}, "pairedItem": {"item": 0}}]';

diff --git a/cypress/e2e/14-data-transformation-expressions.cy.ts b/cypress/e2e/14-data-transformation-expressions.cy.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-use-before-define */
 import { WorkflowPage, NDV } from '../pages';
 
 const wf = new WorkflowPage();

diff --git a/cypress/e2e/20-workflow-executions.cy.ts b/cypress/e2e/20-workflow-executions.cy.ts
@@ -89,7 +89,7 @@ describe('Current Workflow Executions', () => {
 			.should('be.visible')
 			.its('0.contentDocument.body') // Access the body of the iframe document
 			.should('not.be.empty') // Ensure the body is not empty
-			// eslint-disable-next-line @typescript-eslint/unbound-method
+
 			.then(cy.wrap)
 			.find('.el-notification:has(.el-notification--error)')
 			.should('be.visible')

diff --git a/cypress/e2e/2106-ADO-pinned-data-execution-preview.cy.ts b/cypress/e2e/2106-ADO-pinned-data-execution-preview.cy.ts
@@ -36,7 +36,7 @@ describe('ADO-2106 connections should be colored correctly for pinned data in ex
 			.should('be.visible')
 			.its('0.contentDocument.body')
 			.should('not.be.empty')
-			// eslint-disable-next-line @typescript-eslint/unbound-method
+
 			.then(cy.wrap)
 			.find('.jtk-connector[data-source-node="Webhook"][data-target-node="Set"]')
 			.should('have.class', 'success')
@@ -56,7 +56,7 @@ describe('ADO-2106 connections should be colored correctly for pinned data in ex
 			.should('be.visible')
 			.its('0.contentDocument.body')
 			.should('not.be.empty')
-			// eslint-disable-next-line @typescript-eslint/unbound-method
+
 			.then(cy.wrap)
 			.find('.jtk-connector[data-source-node="Webhook"][data-target-node="Set"]')
 			.should('have.class', 'success')

diff --git a/packages/@n8n/client-oauth2/src/ClientOAuth2Token.ts b/packages/@n8n/client-oauth2/src/ClientOAuth2Token.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import type { ClientOAuth2, ClientOAuth2Options, ClientOAuth2RequestObject } from './ClientOAuth2';
 import { auth, expects, getRequestOptions } from './utils';
 import { DEFAULT_HEADERS } from './constants';

diff --git a/packages/@n8n/client-oauth2/src/constants.ts b/packages/@n8n/client-oauth2/src/constants.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import type { Headers } from './types';
 
 export const DEFAULT_URL_BASE = 'https://example.org/';

diff --git a/packages/@n8n/nodes-langchain/nodes/tools/ToolHttpRequest/ToolHttpRequest.node.ts b/packages/@n8n/nodes-langchain/nodes/tools/ToolHttpRequest/ToolHttpRequest.node.ts
@@ -9,6 +9,7 @@ import type {
 } from 'n8n-workflow';
 import { NodeConnectionType, NodeOperationError, tryToParseAlphanumericString } from 'n8n-workflow';
 
+import { DynamicTool } from '@langchain/core/tools';
 import { getConnectionHintNoticeField } from '../../../utils/sharedFields';
 
 import {
@@ -31,8 +32,6 @@ import {
 
 import type { PlaceholderDefinition, ToolParameter } from './interfaces';
 
-import { DynamicTool } from '@langchain/core/tools';
-
 export class ToolHttpRequest implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'HTTP Request Tool',

diff --git a/packages/@n8n/nodes-langchain/nodes/tools/ToolHttpRequest/utils.ts b/packages/@n8n/nodes-langchain/nodes/tools/ToolHttpRequest/utils.ts
@@ -10,15 +10,6 @@ import { NodeConnectionType, NodeOperationError, jsonParse } from 'n8n-workflow'
 
 import { getOAuth2AdditionalParameters } from 'n8n-nodes-base/dist/nodes/HttpRequest/GenericFunctions';
 
-import type {
-	ParameterInputType,
-	ParametersValues,
-	PlaceholderDefinition,
-	ParametersValues as RawParametersValues,
-	SendIn,
-	ToolParameter,
-} from './interfaces';
-
 import set from 'lodash/set';
 import get from 'lodash/get';
 import unset from 'lodash/unset';
@@ -28,6 +19,14 @@ import { convert } from 'html-to-text';
 
 import { Readability } from '@mozilla/readability';
 import { JSDOM } from 'jsdom';
+import type {
+	ParameterInputType,
+	ParametersValues,
+	PlaceholderDefinition,
+	ParametersValues as RawParametersValues,
+	SendIn,
+	ToolParameter,
+} from './interfaces';
 
 const genericCredentialRequest = async (ctx: IExecuteFunctions, itemIndex: number) => {
 	const genericType = ctx.getNodeParameter('genericAuthType', itemIndex) as string;

diff --git a/packages/cli/src/Db.ts b/packages/cli/src/Db.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/restrict-template-expressions */
 import { Container } from 'typedi';
 // eslint-disable-next-line n8n-local-rules/misplaced-n8n-typeorm-import
 import type { EntityManager } from '@n8n/typeorm';

diff --git a/packages/cli/src/ExternalHooks.ts b/packages/cli/src/ExternalHooks.ts
@@ -24,14 +24,12 @@ export class ExternalHooks {
 		credentialsRepository: CredentialsRepository,
 		workflowRepository: WorkflowRepository,
 	) {
-		/* eslint-disable @typescript-eslint/naming-convention */
 		this.dbCollections = {
 			User: userRepository,
 			Settings: settingsRepository,
 			Credentials: credentialsRepository,
 			Workflow: workflowRepository,
 		};
-		/* eslint-enable @typescript-eslint/naming-convention */
 	}
 
 	async init(): Promise<void> {

diff --git a/packages/cli/src/Interfaces.ts b/packages/cli/src/Interfaces.ts
@@ -232,12 +232,10 @@ export interface IExternalHooksFileData {
 
 export interface IExternalHooksFunctions {
 	dbCollections: {
-		/* eslint-disable @typescript-eslint/naming-convention */
 		User: UserRepository;
 		Settings: SettingsRepository;
 		Credentials: CredentialsRepository;
 		Workflow: WorkflowRepository;
-		/* eslint-enable @typescript-eslint/naming-convention */
 	};
 }
 

diff --git a/packages/cli/src/Ldap/helpers.ts b/packages/cli/src/Ldap/helpers.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-use-before-define */
 import type { Entry as LdapUser } from 'ldapts';
 import { Filter } from 'ldapts/filters/Filter';
 import { Container } from 'typedi';

diff --git a/packages/cli/src/PublicApi/index.ts b/packages/cli/src/PublicApi/index.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { Container } from 'typedi';
 import type { Router } from 'express';
 import express from 'express';

diff --git a/packages/cli/src/WebhookHelpers.ts b/packages/cli/src/WebhookHelpers.ts
@@ -197,7 +197,6 @@ export function encodeWebhookResponse(
 ): IExecuteResponsePromiseData {
 	if (typeof response === 'object' && Buffer.isBuffer(response.body)) {
 		response.body = {
-			// eslint-disable-next-line @typescript-eslint/naming-convention
 			'__@N8nEncodedBuffer@__': response.body.toString(BINARY_ENCODING),
 		};
 	}

diff --git a/packages/cli/src/WorkflowExecuteAdditionalData.ts b/packages/cli/src/WorkflowExecuteAdditionalData.ts
@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-use-before-define */
-/* eslint-disable id-denylist */
+
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 import { WorkflowExecute } from 'n8n-core';

diff --git a/packages/cli/src/WorkflowHelpers.ts b/packages/cli/src/WorkflowHelpers.ts
@@ -219,7 +219,7 @@ export async function replaceInvalidCredentials(workflow: WorkflowEntity): Promi
 				credentialsById[nodeCredentialType][nodeCredentials.id];
 		}
 	}
-	/* eslint-enable no-await-in-loop */
+
 	return workflow;
 }
 

diff --git a/packages/cli/src/commands/audit.ts b/packages/cli/src/commands/audit.ts
@@ -24,7 +24,7 @@ export class SecurityAudit extends BaseCommand {
 			default: RISK_CATEGORIES.join(','),
 			description: 'Comma-separated list of categories to include in the audit',
 		}),
-		// eslint-disable-next-line @typescript-eslint/naming-convention
+
 		'days-abandoned-workflow': Flags.integer({
 			default: config.getEnv('security.audit.daysAbandonedWorkflow'),
 			description: 'Days for a workflow to be considered abandoned if not executed',

diff --git a/packages/cli/src/config/types.ts b/packages/cli/src/config/types.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 import type { BinaryData } from 'n8n-core';
 import type { schema } from './schema';
 import type { RedisOptions } from 'ioredis';

diff --git a/packages/cli/src/controllers/oauth/oAuth1Credential.controller.ts b/packages/cli/src/controllers/oauth/oAuth1Credential.controller.ts
@@ -20,11 +20,9 @@ interface OAuth1CredentialData {
 }
 
 const algorithmMap = {
-	/* eslint-disable @typescript-eslint/naming-convention */
 	'HMAC-SHA256': 'sha256',
 	'HMAC-SHA512': 'sha512',
 	'HMAC-SHA1': 'sha1',
-	/* eslint-enable */
 } as const;
 
 @RestController('/oauth1-credential')
@@ -52,7 +50,7 @@ export class OAuth1CredentialController extends AbstractOAuthController {
 				secret: oauthCredentials.consumerSecret,
 			},
 			signature_method: signatureMethod,
-			// eslint-disable-next-line @typescript-eslint/naming-convention
+
 			hash_function(base, key) {
 				const algorithm = algorithmMap[signatureMethod] ?? 'sha1';
 				return createHmac(algorithm, key).update(base).digest('base64');

diff --git a/packages/cli/src/databases/entities/index.ts b/packages/cli/src/databases/entities/index.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { AuthIdentity } from './AuthIdentity';
 import { AuthProviderSyncHistory } from './AuthProviderSyncHistory';
 import { AuthUser } from './AuthUser';

diff --git a/packages/cli/src/databases/migrations/mysqldb/1690000000001-MigrateIntegerKeysToString.ts b/packages/cli/src/databases/migrations/mysqldb/1690000000001-MigrateIntegerKeysToString.ts
@@ -11,7 +11,7 @@ export class MigrateIntegerKeysToString1690000000001 implements IrreversibleMigr
 		if (databaseType === 'mariadb') {
 			collation = COLLATION_57;
 		} else {
-			const dbVersionQuery = (await queryRunner.query('SELECT @@version')) as  // eslint-disable-next-line @typescript-eslint/naming-convention
+			const dbVersionQuery = (await queryRunner.query('SELECT @@version')) as
 				| Array<{ '@@version': string }>
 				| undefined;
 			collation = COLLATION_80;

diff --git a/packages/cli/src/databases/utils/customValidators.ts b/packages/cli/src/databases/utils/customValidators.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { registerDecorator } from 'class-validator';
 
 export function NoXss() {

diff --git a/packages/cli/src/decorators/OnShutdown.ts b/packages/cli/src/decorators/OnShutdown.ts
@@ -24,7 +24,6 @@ import { type ServiceClass, ShutdownService } from '@/shutdown/Shutdown.service'
 export const OnShutdown =
 	(priority = 100): MethodDecorator =>
 	(prototype, propertyKey, descriptor) => {
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		const serviceClass = prototype.constructor as ServiceClass;
 		const methodName = String(propertyKey);
 		// TODO: assert that serviceClass is decorated with @Service

diff --git a/packages/cli/src/environments/sourceControl/sourceControlGit.service.ee.ts b/packages/cli/src/environments/sourceControl/sourceControlGit.service.ee.ts
@@ -317,7 +317,6 @@ export class SourceControlGitService {
 		await this.setGitSshCommand();
 		const params = {};
 		if (options.ffOnly) {
-			// eslint-disable-next-line @typescript-eslint/naming-convention
 			Object.assign(params, { '--ff-only': true });
 		}
 		return await this.git.pull(params);

diff --git a/packages/cli/src/eventbus/MessageEventBusDestination/MessageEventBusDestinationWebhook.ee.ts b/packages/cli/src/eventbus/MessageEventBusDestination/MessageEventBusDestinationWebhook.ee.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 
 import { MessageEventBusDestination } from './MessageEventBusDestination.ee';

diff --git a/packages/cli/src/middlewares/listQuery/dtos/base.filter.dto.ts b/packages/cli/src/middlewares/listQuery/dtos/base.filter.dto.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 import { isObjectLiteral } from '@/utils';
 import { plainToInstance, instanceToPlain } from 'class-transformer';
 import { validate } from 'class-validator';

diff --git a/packages/cli/src/middlewares/listQuery/dtos/base.select.dto.ts b/packages/cli/src/middlewares/listQuery/dtos/base.select.dto.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 import { isStringArray } from '@/utils';
 import { ApplicationError, jsonParse } from 'n8n-workflow';
 

diff --git a/packages/cli/src/security-audit/risk-reporters/InstanceRiskReporter.ts b/packages/cli/src/security-audit/risk-reporters/InstanceRiskReporter.ts
@@ -146,7 +146,6 @@ export class InstanceRiskReporter implements RiskReporter {
 		const { instanceId } = this.instanceSettings;
 
 		const response = await axios.get<n8n.Version[]>(BASE_URL + currentVersionName, {
-			// eslint-disable-next-line @typescript-eslint/naming-convention
 			headers: { 'n8n-instance-id': instanceId },
 		});
 

diff --git a/packages/cli/src/services/frontend.service.ts b/packages/cli/src/services/frontend.service.ts
@@ -56,7 +56,6 @@ export class FrontendService {
 		this.initSettings();
 
 		if (config.getEnv('nodes.communityPackages.enabled')) {
-			// eslint-disable-next-line @typescript-eslint/naming-convention
 			void import('@/services/communityPackages.service').then(({ CommunityPackagesService }) => {
 				this.communityPackagesService = Container.get(CommunityPackagesService);
 			});

diff --git a/packages/cli/src/services/orchestration/worker/handleCommandMessageWorker.ts b/packages/cli/src/services/orchestration/worker/handleCommandMessageWorker.ts
@@ -130,7 +130,6 @@ export function getWorkerCommandReceivedHandler(options: WorkerCommandReceivedHa
 						}
 
 						logger.debug(
-							// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
 							`Received unknown command via channel ${COMMAND_REDIS_CHANNEL}: "${message.command}"`,
 						);
 						break;

diff --git a/packages/cli/src/services/redis/RedisServiceBaseClasses.ts b/packages/cli/src/services/redis/RedisServiceBaseClasses.ts
@@ -46,7 +46,6 @@ class RedisServiceBase {
 
 		this.redisClient.on('error', (error) => {
 			if (!String(error).includes('ECONNREFUSED')) {
-				// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 				this.logger.warn('Error with Redis: ', error);
 			}
 		});

diff --git a/packages/cli/src/sso/saml/serviceProvider.ee.ts b/packages/cli/src/sso/saml/serviceProvider.ee.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
 import { Container } from 'typedi';
 import type { ServiceProviderInstance } from 'samlify';
 import { UrlService } from '@/services/url.service';

diff --git a/packages/cli/src/sso/saml/types/requests.ts b/packages/cli/src/sso/saml/types/requests.ts
@@ -9,7 +9,6 @@ export declare namespace SamlConfiguration {
 		{},
 		{},
 		{
-			// eslint-disable-next-line @typescript-eslint/naming-convention
 			RelayState?: string;
 		},
 		{}

diff --git a/packages/cli/test/integration/commands/reset.cmd.test.ts b/packages/cli/test/integration/commands/reset.cmd.test.ts
@@ -29,7 +29,6 @@ beforeEach(async () => {
 	await testDb.truncate(['User']);
 });
 
-// eslint-disable-next-line n8n-local-rules/no-skipped-tests
 test('user-management:reset should reset DB to default user state', async () => {
 	//
 	// ARRANGE

diff --git a/packages/core/src/NodeExecuteFunctions.ts b/packages/core/src/NodeExecuteFunctions.ts
@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable @typescript-eslint/prefer-nullish-coalescing */
-/* eslint-disable @typescript-eslint/naming-convention */
+
 /* eslint-disable @typescript-eslint/no-unsafe-call */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/no-unsafe-return */
@@ -454,7 +454,6 @@ export async function parseRequestObject(requestObject: IRequestOptions) {
 		// Check support for sendImmediately
 		if (requestObject.auth.bearer !== undefined) {
 			axiosConfig.headers = Object.assign(axiosConfig.headers || {}, {
-				// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
 				Authorization: `Bearer ${requestObject.auth.bearer}`,
 			});
 		} else {

diff --git a/packages/core/src/ObjectStore/ObjectStore.service.ee.ts b/packages/core/src/ObjectStore/ObjectStore.service.ee.ts
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/naming-convention */
-
 import { createHash } from 'node:crypto';
 import axios from 'axios';
 import { Service } from 'typedi';

diff --git a/packages/core/src/WorkflowExecute.ts b/packages/core/src/WorkflowExecute.ts
@@ -1087,9 +1087,8 @@ export class WorkflowExecute {
 								}
 
 								if (nodeSuccessData instanceof NodeExecutionOutput) {
-									// eslint-disable-next-line @typescript-eslint/no-unsafe-call
 									const hints: NodeExecutionHint[] = nodeSuccessData.getHints();
-									// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
+
 									executionHints.push(...hints);
 								}
 

diff --git a/packages/editor-ui/src/__tests__/setup.ts b/packages/editor-ui/src/__tests__/setup.ts
@@ -22,7 +22,9 @@ Range.prototype.getClientRects = vi.fn(() => ({
 
 export class IntersectionObserver {
 	root = null;
+
 	rootMargin = '';
+
 	thresholds = [];
 
 	disconnect() {

diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialConfig.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialConfig.vue
@@ -38,8 +38,8 @@
 			:message="$locale.baseText('credentialEdit.credentialConfig.accountConnected')"
 			:button-label="$locale.baseText('credentialEdit.credentialConfig.reconnect')"
 			:button-title="$locale.baseText('credentialEdit.credentialConfig.reconnectOAuth2Credential')"
-			@click="$emit('oauth')"
 			data-test-id="oauth-connect-success-banner"
+			@click="$emit('oauth')"
 		>
 			<template v-if="isGoogleOAuthType" #button>
 				<p
@@ -118,8 +118,8 @@
 				isOAuthType && requiredPropertiesFilled && !isOAuthConnected && credentialPermissions.update
 			"
 			:is-google-o-auth-type="isGoogleOAuthType"
-			@click="$emit('oauth')"
 			data-test-id="oauth-connect-button"
+			@click="$emit('oauth')"
 		/>
 
 		<n8n-text v-if="isMissingCredentials" color="text-base" size="medium">

diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
@@ -665,7 +665,7 @@ export default defineComponent({
 					};
 				}
 
-				this.credentialName = currentCredentials.name as string;
+				this.credentialName = currentCredentials.name;
 			} catch (error) {
 				this.showError(
 					error,

diff --git a/packages/editor-ui/src/components/ExternalSecretsProviderConnectionSwitch.ee.vue b/packages/editor-ui/src/components/ExternalSecretsProviderConnectionSwitch.ee.vue
@@ -48,7 +48,7 @@ async function onUpdateConnected(value: boolean) {
 
 		if (props.beforeUpdate) {
 			const result = await props.beforeUpdate(value);
-			if (result === false) {
+			if (!result) {
 				saving.value = false;
 				return;
 			}

diff --git a/packages/editor-ui/src/components/NpsSurvey.vue b/packages/editor-ui/src/components/NpsSurvey.vue
@@ -154,7 +154,7 @@ watch(
 					</div>
 				</div>
 				<div v-else :class="$style.email">
-					<div :class="$style.input" @keyup.enter="send" data-test-id="nps-survey-email">
+					<div :class="$style.input" data-test-id="nps-survey-email" @keyup.enter="send">
 						<n8n-input
 							v-model="form.email"
 							:placeholder="YOUR_EMAIL_ADDRESS"