move the check earlier in the constructor

n8n-io · Jan 16, 2024 · 4931730 · 4931730
1 parent 8fc7385
commit 4931730
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/packages/workflow/src/errors/abstract/node.error.ts b/packages/workflow/src/errors/abstract/node.error.ts
@@ -35,18 +35,16 @@ const COMMON_ERRORS: IDataObject = {
  * a value recursively inside an error object.
  */
 export abstract class NodeError extends ExecutionBaseError {
-	node: INode;
-
-	constructor(node: INode, error: Error | JsonObject) {
-		if (error instanceof Error) {
-			super(error.message, { cause: error });
-		} else {
-			super('', { errorResponse: error });
-		}
-
-		this.node = node;
-
+	constructor(
+		readonly node: INode,
+		error: Error | JsonObject,
+	) {
 		if (error instanceof NodeError) return error;
+
+		const isError = error instanceof Error;
+		const message = isError ? error.message : '';
+		const options = isError ? { cause: error } : { errorResponse: error };
+		super(message, options);
 	}
 
 	/**