⚡ Hiding assistant button for custom nodes, fixing banner border in d…

…ark mode
n8n-io · Jul 29, 2024 · 4c24b73 · 4c24b73
1 parent 67e637c
commit 4c24b73
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/packages/design-system/src/components/InlineAskAssistantButton/InlineAskAssistantButton.vue b/packages/design-system/src/components/InlineAskAssistantButton/InlineAskAssistantButton.vue
@@ -128,4 +128,3 @@ const onClick = () => {
 	margin-bottom: -1px; // center icon to align with text
 }
 </style>
-../AskAssistantText/AssistantText.vue../AskAssistantIcon/AssistantIcon.vue
diff --git a/packages/design-system/src/css/_tokens.dark.scss b/packages/design-system/src/css/_tokens.dark.scss
@@ -195,7 +195,7 @@
 	--color-notice-font: var(--prim-gray-0);
 
 	// Callout
-	--color-callout-info-border: var(--prim-gray-420);
+	--color-callout-info-border: var(--prim-gray-670);
 	--color-callout-info-background: var(--prim-gray-740);
 	--color-callout-info-font: var(--prim-gray-0);
 	--color-callout-success-border: var(--color-success);

diff --git a/packages/editor-ui/src/components/Error/NodeErrorView.vue b/packages/editor-ui/src/components/Error/NodeErrorView.vue
@@ -22,6 +22,7 @@ import { useAssistantStore } from '@/stores/assistant.store';
 import type { ChatRequest } from '@/types/assistant.types';
 import InlineAskAssistantButton from 'n8n-design-system/components/InlineAskAssistantButton/InlineAskAssistantButton.vue';
 import { useUIStore } from '@/stores/ui.store';
+import { isCommunityPackageName } from '@/utils/nodeTypesUtils';
 
 type Props = {
 	// TODO: .node can be undefined
@@ -110,6 +111,11 @@ const prepareRawMessages = computed(() => {
 	return returnData;
 });
 
+const isAskAssistantAvailable = computed(() => {
+	const isCustomNode = props.error.node?.type === undefined || isCommunityPackageName(props.error.node);
+	return assistantStore.canShowAssistantButtons && !isCustomNode;
+});
+
 const assistantAlreadyAsked = computed(() => {
 	return assistantStore.isNodeErrorActive({
 		error: simplifyErrorForAssistant(props.error),
@@ -435,7 +441,7 @@ async function onAskAssistantClick() {
 				class="node-error-view__header-description"
 				v-html="getErrorDescription()"
 			></div>
-			<div v-if="assistantStore.canShowAssistantButtons" class="node-error-view__assistant-button">
+			<div v-if="isAskAssistantAvailable" class="node-error-view__assistant-button">
 				<InlineAskAssistantButton :asked="assistantAlreadyAsked" @click="onAskAssistantClick" />
 			</div>
 		</div>

diff --git a/packages/editor-ui/src/stores/assistant.store.ts b/packages/editor-ui/src/stores/assistant.store.ts
@@ -468,5 +468,6 @@ export const useAssistantStore = defineStore(STORES.ASSISTANT, () => {
 		sendMessage,
 		applyCodeDiff,
 		undoCodeDiff,
+		resetAssistantChat,
 	};
 });