feat(editor): Improve errors in output panel (#8644)

Co-authored-by: Michael Kret <michael.k@radency.com>
n8n-io · Mar 7, 2024 · 5301323 · 5301323
1 parent 6e2aa40
commit 5301323
Show file tree

Hide file tree

Showing 38 changed files with 758 additions and 273 deletions.
diff --git a/packages/@n8n/nodes-langchain/nodes/vendors/OpenAi/actions/router.ts b/packages/@n8n/nodes-langchain/nodes/vendors/OpenAi/actions/router.ts
@@ -1,4 +1,9 @@
-import { NodeOperationError, type IExecuteFunctions, type INodeExecutionData } from 'n8n-workflow';
+import {
+	NodeOperationError,
+	type IExecuteFunctions,
+	type INodeExecutionData,
+	NodeApiError,
+} from 'n8n-workflow';
 
 import * as assistant from './assistant';
 import * as audio from './audio';
@@ -54,6 +59,15 @@ export async function router(this: IExecuteFunctions) {
 				returnData.push({ json: { error: error.message }, pairedItem: { item: i } });
 				continue;
 			}
+
+			if (error instanceof NodeApiError) {
+				error.context = {
+					itemIndex: i,
+				};
+
+				throw error;
+			}
+
 			throw new NodeOperationError(this.getNode(), error, {
 				itemIndex: i,
 				description: error.description,

diff --git a/packages/cli/src/services/frontend.service.ts b/packages/cli/src/services/frontend.service.ts
@@ -98,6 +98,7 @@ export class FrontendService {
 			timezone: config.getEnv('generic.timezone'),
 			urlBaseWebhook: this.urlService.getWebhookBaseUrl(),
 			urlBaseEditor: instanceBaseUrl,
+			binaryDataMode: config.getEnv('binaryDataManager.mode'),
 			versionCli: '',
 			releaseChannel: config.getEnv('generic.releaseChannel'),
 			oauthCallbackUrls: {
@@ -308,6 +309,8 @@ export class FrontendService {
 
 		this.settings.executionMode = config.getEnv('executions.mode');
 
+		this.settings.binaryDataMode = config.getEnv('binaryDataManager.mode');
+
 		return this.settings;
 	}
 

diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts
@@ -1106,6 +1106,7 @@ export interface RootState {
 	urlBaseEditor: string;
 	instanceId: string;
 	isNpmAvailable: boolean;
+	binaryDataMode: string;
 }
 
 export interface NodeMetadataMap {
@@ -1154,6 +1155,7 @@ export interface IRootState {
 	nodeMetadata: NodeMetadataMap;
 	isNpmAvailable: boolean;
 	subworkflowExecutionError: Error | null;
+	binaryDataMode: string;
 }
 
 export interface CommunityPackageMap {

diff --git a/packages/editor-ui/src/__tests__/server/endpoints/settings.ts b/packages/editor-ui/src/__tests__/server/endpoints/settings.ts
@@ -92,6 +92,7 @@ const defaultSettings: IN8nUISettings = {
 	banners: {
 		dismissed: [],
 	},
+	binaryDataMode: 'default',
 };
 
 export function routesForSettings(server: Server) {

diff --git a/packages/editor-ui/src/__tests__/utils.ts b/packages/editor-ui/src/__tests__/utils.ts
@@ -144,4 +144,5 @@ export const SETTINGS_STORE_DEFAULT_STATE: ISettingsState = {
 	saveDataErrorExecution: 'all',
 	saveDataSuccessExecution: 'all',
 	saveManualExecutions: false,
+	binaryDataMode: 'default',
 };