Skip to content

Commit

Permalink
feat: Expand obfuscation to User Management credential sharing (#4070)
Browse files Browse the repository at this point in the history
⚡ Expand obfuscation
  • Loading branch information
ivov authored Sep 14, 2022
1 parent 9f1189f commit 5969e47
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/CredentialCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<credential-icon :credential-type-name="credentialType ? credentialType.name : ''" />
</template>
<template #header>
<n8n-heading tag="h2" bold :class="$style['card-heading']">
<n8n-heading tag="h2" bold class="ph-no-capture" :class="$style['card-heading']">
{{ data.name }}
</n8n-heading>
</template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@
v-else
:features="[EnterpriseEditionFeature.Sharing]"
>
<n8n-info-tip :bold="false">
{{ $locale.baseText('credentialEdit.credentialEdit.info.sharee', { interpolate: { credentialOwnerName } }) }}
</n8n-info-tip>
<div class="ph-no-capture">
<n8n-info-tip :bold="false">
{{ $locale.baseText('credentialEdit.credentialEdit.info.sharee', { interpolate: { credentialOwnerName } }) }}
</n8n-info-tip>
</div>
</enterprise-edition>

<CredentialInputs
Expand Down
4 changes: 2 additions & 2 deletions packages/editor-ui/src/components/Node.vue
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@
<div :class="{'disabled-linethrough': true, success: workflowDataItems > 0}" v-if="showDisabledLinethrough"></div>
</div>
<div class="node-description">
<div class="node-name" :title="nodeTitle">
<div class="node-name ph-no-capture" :title="nodeTitle">
<p>
{{ nodeTitle }}
</p>
<p v-if="data.disabled">
({{ $locale.baseText('node.disabled') }})
</p>
</div>
<div v-if="nodeSubtitle !== undefined" class="node-subtitle ph-no-capture" :title="nodeSubtitle">
<div v-if="nodeSubtitle !== undefined" class="node-subtitle" :title="nodeSubtitle">
{{ nodeSubtitle }}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/NodeTitle.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<n8n-button type="primary" size="small" @click="onRename" :label="$locale.baseText('ndv.title.rename')" />
</div>
</div>
<div slot="reference" :class="{[$style.title]: true, [$style.hoverable]: !readOnly}">
<div class="ph-no-capture" slot="reference" :class="{[$style.title]: true, [$style.hoverable]: !readOnly}">
{{ value }}
<div :class="$style.editIconContainer">
<font-awesome-icon :class="$style.editIcon" icon="pencil-alt" v-if="!readOnly" />
Expand Down
4 changes: 3 additions & 1 deletion packages/editor-ui/src/views/CredentialsView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<n8n-loading :class="$style['card-loading']" variant="custom"/>
</div>
<template v-else>
<div v-if="allCredentials.length === 0">
<div class="ph-no-capture" v-if="allCredentials.length === 0">
<n8n-action-box
emoji="👋"
:heading="$locale.baseText(currentUser.firstName ? 'credentials.empty.heading' : 'credentials.empty.heading.userNotSetup', {
Expand Down Expand Up @@ -133,6 +133,7 @@
/>
<n8n-select
v-model="filters.ownedBy"
class="ph-no-capture"
:class="$style['user-select']"
size="small"
filterable
Expand Down Expand Up @@ -167,6 +168,7 @@
/>
<n8n-select
v-model="filters.sharedWith"
class="ph-no-capture"
:class="$style['user-select']"
size="small"
filterable
Expand Down

0 comments on commit 5969e47

Please sign in to comment.