Skip to content

Commit

Permalink
fix(editor): Fix issue with synchronization table on LDAP not loading…
Browse files Browse the repository at this point in the history
… data (#8327)

## Summary

When we migrated to Vue3, we updated to a new component and did not provide the right props. 

before:

https://www.loom.com/share/ce12b21fdda44176b3e949a00c582252


now:

https://www.loom.com/share/354d1dcb51bd47a9910d5bfe34c7c9b8


## Related tickets and issues
https://linear.app/n8n/issue/PAY-1134/ldap-synchronization-table-in-ui-remains-empty-even-after-successful

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
  • Loading branch information
RicardoE105 authored Jan 15, 2024
1 parent 3c2a400 commit 6b92d49
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions packages/editor-ui/src/views/SettingsLdapView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
:data="dataTable"
:cell-style="cellClassStyle"
style="width: 100%"
height="250"
max-height="250"
>
<ElTableColumn
prop="status"
Expand Down Expand Up @@ -110,10 +110,7 @@
$locale.baseText('settings.ldap.synchronizationTable.empty.message')
}}</template>
<template #append>
<InfiniteLoading
force-use-infinite-wrapper=".el-table__body-wrapper"
@infinite="getLdapSynchronizations"
>
<InfiniteLoading target=".el-table__body-wrapper" @infinite="getLdapSynchronizations">
</InfiniteLoading>
</template>
</ElTable>
Expand Down

0 comments on commit 6b92d49

Please sign in to comment.