revert InternalHooks.init

will revisit in another PR
n8n-io · Oct 23, 2023 · 6d40dc8 · 6d40dc8
1 parent 4ea8662
commit 6d40dc8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/cli/src/InternalHooks.ts b/packages/cli/src/InternalHooks.ts
@@ -67,6 +67,10 @@ export class InternalHooks implements IInternalHooksClass {
 		);
 	}
 
+	async init() {
+		await this.telemetry.init();
+	}
+
 	async onServerStarted(
 		diagnosticInfo: IDiagnosticInfo,
 		earliestWorkflowCreatedAt?: Date,

diff --git a/packages/cli/src/WorkflowRunnerProcess.ts b/packages/cli/src/WorkflowRunnerProcess.ts
@@ -55,7 +55,6 @@ import { PermissionChecker } from '@/UserManagement/PermissionChecker';
 import { License } from '@/License';
 import { InternalHooks } from '@/InternalHooks';
 import { PostHogClient } from '@/posthog';
-import { Telemetry } from './telemetry';
 
 if (process.env.NODEJS_PREFER_IPV4 === 'true') {
 	setDefaultResultOrder('ipv4first');
@@ -117,8 +116,8 @@ class WorkflowRunnerProcess {
 		const externalHooks = Container.get(ExternalHooks);
 		await externalHooks.init();
 
-		await Container.get(Telemetry).init();
 		await Container.get(PostHogClient).init();
+		await Container.get(InternalHooks).init();
 
 		const binaryDataConfig = config.getEnv('binaryDataManager');
 		await Container.get(BinaryDataService).init(binaryDataConfig);

diff --git a/packages/cli/src/commands/BaseCommand.ts b/packages/cli/src/commands/BaseCommand.ts
@@ -14,13 +14,13 @@ import { ExternalHooks } from '@/ExternalHooks';
 import { NodeTypes } from '@/NodeTypes';
 import { LoadNodesAndCredentials } from '@/LoadNodesAndCredentials';
 import type { IExternalHooksClass, N8nInstanceType } from '@/Interfaces';
+import { InternalHooks } from '@/InternalHooks';
 import { PostHogClient } from '@/posthog';
 import { License } from '@/License';
 import { ExternalSecretsManager } from '@/ExternalSecrets/ExternalSecretsManager.ee';
 import { initExpressionEvaluator } from '@/ExpressionEvalator';
 import { generateHostInstanceId } from '../databases/utils/generators';
 import { WorkflowHistoryManager } from '@/workflows/workflowHistory/workflowHistoryManager.ee';
-import { Telemetry } from '@/telemetry';
 
 export abstract class BaseCommand extends Command {
 	protected logger = LoggerProxy.init(getLogger());
@@ -73,8 +73,8 @@ export abstract class BaseCommand extends Command {
 			);
 		}
 
-		await Container.get(Telemetry).init();
 		await Container.get(PostHogClient).init();
+		await Container.get(InternalHooks).init();
 	}
 
 	protected setInstanceType(instanceType: N8nInstanceType) {