fix: Properly output saml validation errors (#8284)

n8n-io · Jan 10, 2024 · 8c7f399 · 8c7f399
1 parent 53612de
commit 8c7f399
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/packages/cli/src/sso/saml/samlValidator.ts b/packages/cli/src/sso/saml/samlValidator.ts
@@ -88,7 +88,13 @@ export async function validateMetadata(metadata: string): Promise<boolean> {
 			return true;
 		} else {
 			logger.warn('SAML Validate Metadata: Invalid metadata');
-			logger.warn(validationResult ? validationResult.errors.join('\n') : '');
+			logger.warn(
+				validationResult
+					? validationResult.errors
+							.map((error) => `${error.message} - ${error.rawMessage}`)
+							.join('\n')
+					: '',
+			);
 		}
 	} catch (error) {
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
@@ -118,7 +124,13 @@ export async function validateResponse(response: string): Promise<boolean> {
 			return true;
 		} else {
 			logger.warn('SAML Validate Response: Failed');
-			logger.warn(validationResult ? validationResult.errors.join('\n') : '');
+			logger.warn(
+				validationResult
+					? validationResult.errors
+							.map((error) => `${error.message} - ${error.rawMessage}`)
+							.join('\n')
+					: '',
+			);
 		}
 	} catch (error) {
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument