feat(Salesforce Node): Add country field (#3314)

n8n-io · May 24, 2022 · 90a1bc1 · 90a1bc1
1 parent 5c5de0c
commit 90a1bc1
Show file tree

Hide file tree

Showing 9 changed files with 102 additions and 88 deletions.
diff --git a/packages/nodes-base/nodes/Salesforce/AccountDescription.ts b/packages/nodes-base/nodes/Salesforce/AccountDescription.ts
@@ -31,6 +31,11 @@ export const accountOperations: INodeProperties[] = [
 				value: 'upsert',
 				description: 'Create a new account, or update the current one if it already exists (upsert)',
 			},
+			{
+				name: 'Delete',
+				value: 'delete',
+				description: 'Delete an account',
+			},
 			{
 				name: 'Get',
 				value: 'get',
@@ -46,11 +51,6 @@ export const accountOperations: INodeProperties[] = [
 				value: 'getSummary',
 				description: 'Returns an overview of account\'s metadata',
 			},
-			{
-				name: 'Delete',
-				value: 'delete',
-				description: 'Delete an account',
-			},
 			{
 				name: 'Update',
 				value: 'update',
@@ -152,16 +152,6 @@ export const accountFields: INodeProperties[] = [
 				default: '',
 				description: 'Account number assigned to this account (not the unique ID). Maximum size is 40 characters.',
 			},
-			{
-				displayName: 'Account Source',
-				name: 'accountSource',
-				type: 'options',
-				typeOptions: {
-					loadOptionsMethod: 'getAccountSources',
-				},
-				default: '',
-				description: 'The source of the account record',
-			},
 			{
 				displayName: 'Annual Revenue',
 				name: 'annualRevenue',
@@ -172,6 +162,16 @@ export const accountFields: INodeProperties[] = [
 				default: '',
 				description: 'Estimated annual revenue of the account',
 			},
+			{
+				displayName: 'Account Source',
+				name: 'accountSource',
+				type: 'options',
+				typeOptions: {
+					loadOptionsMethod: 'getAccountSources',
+				},
+				default: '',
+				description: 'The source of the account record',
+			},
 			{
 				displayName: 'Billing City',
 				name: 'billingCity',
@@ -290,6 +290,13 @@ export const accountFields: INodeProperties[] = [
 				default: '',
 				description: 'The owner of the account',
 			},
+			{
+				displayName: 'Parent ID',
+				name: 'parentId',
+				type: 'string',
+				default: '',
+				description: 'ID of the parent object, if any',
+			},
 			{
 				displayName: 'Phone',
 				name: 'phone',
@@ -326,13 +333,6 @@ export const accountFields: INodeProperties[] = [
 				},
 				description: 'Type of account',
 			},
-			{
-				displayName: 'Parent ID',
-				name: 'parentId',
-				type: 'string',
-				default: '',
-				description: 'ID of the parent object, if any',
-			},
 			{
 				displayName: 'Shipping City',
 				name: 'shippingCity',
@@ -545,6 +545,19 @@ export const accountFields: INodeProperties[] = [
 				default: '',
 				description: 'References the ID of a company in Data.com',
 			},
+			{
+				displayName: 'Name',
+				name: 'name',
+				type: 'string',
+				default: '',
+				description: 'Name of the account. Maximum size is 255 characters.',
+			},
+			{
+				displayName: 'Number Of Employees',
+				name: 'numberOfEmployees',
+				type: 'number',
+				default: '',
+			},
 			{
 				displayName: 'Owner',
 				name: 'ownerId',
@@ -555,6 +568,13 @@ export const accountFields: INodeProperties[] = [
 				default: '',
 				description: 'The owner of the account',
 			},
+			{
+				displayName: 'Parent ID',
+				name: 'parentId',
+				type: 'string',
+				default: '',
+				description: 'ID of the parent object, if any',
+			},
 			{
 				displayName: 'Phone',
 				name: 'phone',
@@ -571,36 +591,6 @@ export const accountFields: INodeProperties[] = [
 				},
 				default: '',
 			},
-			{
-				displayName: 'Type',
-				name: 'type',
-				type: 'options',
-				default: '',
-				typeOptions: {
-					loadOptionsMethod: 'getAccountTypes',
-				},
-				description: 'Type of account',
-			},
-			{
-				displayName: 'Name',
-				name: 'name',
-				type: 'string',
-				default: '',
-				description: 'Name of the account. Maximum size is 255 characters.',
-			},
-			{
-				displayName: 'Number Of Employees',
-				name: 'numberOfEmployees',
-				type: 'number',
-				default: '',
-			},
-			{
-				displayName: 'Parent ID',
-				name: 'parentId',
-				type: 'string',
-				default: '',
-				description: 'ID of the parent object, if any',
-			},
 			{
 				displayName: 'SicDesc',
 				name: 'sicDesc',
@@ -646,6 +636,16 @@ export const accountFields: INodeProperties[] = [
 				default: '',
 				description: 'The street address of the shipping address for this account. Maximum of 255 characters.',
 			},
+			{
+				displayName: 'Type',
+				name: 'type',
+				type: 'options',
+				default: '',
+				typeOptions: {
+					loadOptionsMethod: 'getAccountTypes',
+				},
+				description: 'Type of account',
+			},
 			{
 				displayName: 'Website',
 				name: 'website',
@@ -906,7 +906,7 @@ export const accountFields: INodeProperties[] = [
 				name: 'isPrivate',
 				type: 'boolean',
 				default: false,
-				description: 'If true, only the note owner or a user with the “Modify All Data” permission can view the note or query it via the API',
+				description: 'Whether true, only the note owner or a user with the “Modify All Data” permission can view the note or query it via the API',
 			},
 			{
 				displayName: 'Owner',

diff --git a/packages/nodes-base/nodes/Salesforce/AttachmentDescription.ts b/packages/nodes-base/nodes/Salesforce/AttachmentDescription.ts
@@ -139,7 +139,7 @@ export const attachmentFields: INodeProperties[] = [
 				name: 'isPrivate',
 				type: 'boolean',
 				default: false,
-				description: 'Indicates whether this record is viewable only by the owner and administrators (true) or viewable by all otherwise-allowed users (false)',
+				description: 'Whether this record is viewable only by the owner and administrators (true) or viewable by all otherwise-allowed users (false)',
 			},
 			{
 				displayName: 'Owner',

diff --git a/packages/nodes-base/nodes/Salesforce/CaseDescription.ts b/packages/nodes-base/nodes/Salesforce/CaseDescription.ts
@@ -24,6 +24,11 @@ export const caseOperations: INodeProperties[] = [
 				value: 'create',
 				description: 'Create a case',
 			},
+			{
+				name: 'Delete',
+				value: 'delete',
+				description: 'Delete a case',
+			},
 			{
 				name: 'Get',
 				value: 'get',
@@ -39,11 +44,6 @@ export const caseOperations: INodeProperties[] = [
 				value: 'getSummary',
 				description: 'Returns an overview of case\'s metadata',
 			},
-			{
-				name: 'Delete',
-				value: 'delete',
-				description: 'Delete a case',
-			},
 			{
 				name: 'Update',
 				value: 'update',
@@ -159,7 +159,7 @@ export const caseFields: INodeProperties[] = [
 				name: 'isEscalated',
 				type: 'boolean',
 				default: false,
-				description: 'Indicates whether the case has been escalated (true) or not',
+				description: 'Whether indicates whether the case has been escalated (true) or not',
 			},
 			{
 				displayName: 'Origin',
@@ -365,7 +365,7 @@ export const caseFields: INodeProperties[] = [
 				name: 'isEscalated',
 				type: 'boolean',
 				default: false,
-				description: 'Indicates whether the case has been escalated (true) or not',
+				description: 'Whether the case has been escalated (true) or not',
 			},
 			{
 				displayName: 'Origin',
@@ -713,7 +713,7 @@ export const caseFields: INodeProperties[] = [
 				name: 'isPublished',
 				type: 'boolean',
 				default: false,
-				description: 'Indicates whether the CaseComment is visible to customers in the Self-Service portal (true) or not (false)',
+				description: 'Whether the CaseComment is visible to customers in the Self-Service portal (true) or not (false)',
 			},
 		],
 	},

diff --git a/packages/nodes-base/nodes/Salesforce/ContactDescription.ts b/packages/nodes-base/nodes/Salesforce/ContactDescription.ts
@@ -26,6 +26,11 @@ export const contactOperations: INodeProperties[] = [
 				value: 'addNote',
 				description: 'Add note to a contact',
 			},
+			{
+				name: 'Delete',
+				value: 'delete',
+				description: 'Delete a contact',
+			},
 			{
 				name: 'Create',
 				value: 'create',
@@ -36,11 +41,6 @@ export const contactOperations: INodeProperties[] = [
 				value: 'upsert',
 				description: 'Create a new contact, or update the current one if it already exists (upsert)',
 			},
-			{
-				name: 'Delete',
-				value: 'delete',
-				description: 'Delete a contact',
-			},
 			{
 				name: 'Get',
 				value: 'get',
@@ -575,7 +575,7 @@ export const contactFields: INodeProperties[] = [
 				name: 'jigsaw',
 				type: 'string',
 				default: '',
-				description: 'references the ID of a contact in Data.com. If a contact has a value in this field, it means that a contact was imported as a contact from Data.com.',
+				description: 'References the ID of a contact in Data.com. If a contact has a value in this field, it means that a contact was imported as a contact from Data.com.',
 			},
 			{
 				displayName: 'Last Name',
@@ -1032,7 +1032,7 @@ export const contactFields: INodeProperties[] = [
 				name: 'isPrivate',
 				type: 'boolean',
 				default: false,
-				description: 'If true, only the note owner or a user with the “Modify All Data” permission can view the note or query it via the API',
+				description: 'Whether only the note owner or a user with the “Modify All Data” permission can view the note or query it via the API',
 			},
 			{
 				displayName: 'Owner',

diff --git a/packages/nodes-base/nodes/Salesforce/CustomObjectDescription.ts b/packages/nodes-base/nodes/Salesforce/CustomObjectDescription.ts
@@ -26,6 +26,11 @@ export const customObjectOperations: INodeProperties[] = [
 				value: 'upsert',
 				description: 'Create a new record, or update the current one if it already exists (upsert)',
 			},
+			{
+				name: 'Delete',
+				value: 'delete',
+				description: 'Delete a custom object record',
+			},
 			{
 				name: 'Get',
 				value: 'get',
@@ -36,11 +41,6 @@ export const customObjectOperations: INodeProperties[] = [
 				value: 'getAll',
 				description: 'Get all custom object records',
 			},
-			{
-				name: 'Delete',
-				value: 'delete',
-				description: 'Delete a custom object record',
-			},
 			{
 				name: 'Update',
 				value: 'update',

diff --git a/packages/nodes-base/nodes/Salesforce/FlowDescription.ts b/packages/nodes-base/nodes/Salesforce/FlowDescription.ts
@@ -74,7 +74,7 @@ export const flowFields: INodeProperties[] = [
 			minValue: 1,
 			maxValue: 500,
 		},
-		default: 100,
+		default: 50,
 		description: 'Max number of results to return',
 	},
 
@@ -114,7 +114,7 @@ export const flowFields: INodeProperties[] = [
 				],
 			},
 		},
-		description: 'If the input variables should be set via the value-key pair UI or JSON/RAW',
+		description: 'Whether the input variables should be set via the value-key pair UI or JSON/RAW',
 	},
 	{
 		displayName: 'Variables',

diff --git a/packages/nodes-base/nodes/Salesforce/LeadDescription.ts b/packages/nodes-base/nodes/Salesforce/LeadDescription.ts
@@ -186,6 +186,13 @@ export const leadFields: INodeProperties[] = [
 				default: '',
 				description: 'City for the address of the lead',
 			},
+			{
+				displayName: 'Country',
+				name: 'country',
+				type: 'string',
+				default: '',
+				description: 'Country of the lead',
+			},
 			{
 				displayName: 'Custom Fields',
 				name: 'customFieldsUi',
@@ -258,14 +265,14 @@ export const leadFields: INodeProperties[] = [
 				name: 'IsUnreadByOwner',
 				type: 'boolean',
 				default: false,
-				description: 'If true, lead has been assigned, but not yet viewed. See Unread Leads for more information. Label is Unread By Owner.',
+				description: 'Whether true, lead has been assigned, but not yet viewed. See Unread Leads for more information. Label is Unread By Owner.',
 			},
 			{
 				displayName: 'Jigsaw',
 				name: 'jigsaw',
 				type: 'string',
 				default: '',
-				description: 'references the ID of a contact in Data.com. If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.',
+				description: 'References the ID of a contact in Data.com. If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.',
 			},
 			{
 				displayName: 'Lead Source',
@@ -441,6 +448,13 @@ export const leadFields: INodeProperties[] = [
 				default: '',
 				description: 'Company of the lead. If person account record types have been enabled, and if the value of Company is null, the lead converts to a person account.',
 			},
+			{
+				displayName: 'Country',
+				name: 'country',
+				type: 'string',
+				default: '',
+				description: 'Country of the lead',
+			},
 			{
 				displayName: 'Custom Fields',
 				name: 'customFieldsUi',
@@ -513,14 +527,14 @@ export const leadFields: INodeProperties[] = [
 				name: 'IsUnreadByOwner',
 				type: 'boolean',
 				default: false,
-				description: 'If true, lead has been assigned, but not yet viewed. See Unread Leads for more information. Label is Unread By Owner.',
+				description: 'Whether true, lead has been assigned, but not yet viewed. See Unread Leads for more information. Label is Unread By Owner.',
 			},
 			{
 				displayName: 'Jigsaw',
 				name: 'jigsaw',
 				type: 'string',
 				default: '',
-				description: 'references the ID of a contact in Data.com. If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.',
+				description: 'References the ID of a contact in Data.com. If a lead has a value in this field, it means that a contact was imported as a lead from Data.com.',
 			},
 			{
 				displayName: 'Last Name',
@@ -960,7 +974,7 @@ export const leadFields: INodeProperties[] = [
 				name: 'isPrivate',
 				type: 'boolean',
 				default: false,
-				description: 'If true, only the note owner or a user with the “Modify All Data” permission can view the note or query it via the API',
+				description: 'Whether true, only the note owner or a user with the “Modify All Data” permission can view the note or query it via the API',
 			},
 			{
 				displayName: 'Owner',