fix: Extension deep compare not quite working for some primitives (#5172

) fix: extension deep compare not quite working for some primitives
n8n-io · Jan 16, 2023 · 98017dc · 98017dc
1 parent 582865c
commit 98017dc
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/workflow/src/Extensions/ArrayExtensions.ts b/packages/workflow/src/Extensions/ArrayExtensions.ts
@@ -16,6 +16,11 @@ function deepCompare(left: unknown, right: unknown): boolean {
 		return true;
 	}
 
+	// Explicitly return false if certain primitives don't equal each other
+	if (['number', 'string', 'bigint', 'boolean', 'symbol'].includes(typeof left) && left !== right) {
+		return false;
+	}
+
 	// Quickly check how many properties each has to avoid checking obviously mismatching
 	// objects
 	if (Object.keys(left as object).length !== Object.keys(right as object).length) {