fix(Toggl Trigger Node): Update API version (#10207)

n8n-io · Aug 21, 2024 · 9bdb1d6 · 9bdb1d6
1 parent 09c3a8b
commit 9bdb1d6
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 16 deletions.
diff --git a/packages/nodes-base/credentials/TogglApi.credentials.ts b/packages/nodes-base/credentials/TogglApi.credentials.ts
@@ -1,4 +1,9 @@
-import type { ICredentialType, INodeProperties } from 'n8n-workflow';
+import type {
+	IAuthenticateGeneric,
+	ICredentialTestRequest,
+	ICredentialType,
+	INodeProperties,
+} from 'n8n-workflow';
 
 export class TogglApi implements ICredentialType {
 	name = 'togglApi';
@@ -9,7 +14,7 @@ export class TogglApi implements ICredentialType {
 
 	properties: INodeProperties[] = [
 		{
-			displayName: 'Username',
+			displayName: 'Email Address',
 			name: 'username',
 			type: 'string',
 			default: '',
@@ -22,4 +27,21 @@ export class TogglApi implements ICredentialType {
 			default: '',
 		},
 	];
+
+	authenticate: IAuthenticateGeneric = {
+		type: 'generic',
+		properties: {
+			auth: {
+				username: '={{$credentials.username}}',
+				password: '={{$credentials.password}}',
+			},
+		},
+	};
+
+	test: ICredentialTestRequest = {
+		request: {
+			baseURL: 'https://api.track.toggl.com/api/v9',
+			url: '/me',
+		},
+	};
 }
diff --git a/packages/nodes-base/nodes/Toggl/GenericFunctions.ts b/packages/nodes-base/nodes/Toggl/GenericFunctions.ts
@@ -24,29 +24,18 @@ export async function togglApiRequest(
 	query?: IDataObject,
 	uri?: string,
 ) {
-	const credentials = await this.getCredentials('togglApi');
-	const headerWithAuthentication = Object.assign(
-		{},
-		{
-			Authorization: ` Basic ${Buffer.from(
-				`${credentials.username}:${credentials.password}`,
-			).toString('base64')}`,
-		},
-	);
-
 	const options: IRequestOptions = {
-		headers: headerWithAuthentication,
 		method,
 		qs: query,
-		uri: uri || `https://api.track.toggl.com/api/v8${resource}`,
+		uri: uri || `https://api.track.toggl.com/api/v9/me${resource}`,
 		body,
 		json: true,
 	};
 	if (Object.keys(options.body as IDataObject).length === 0) {
 		delete options.body;
 	}
 	try {
-		return await this.helpers.request(options);
+		return await this.helpers.requestWithAuthentication.call(this, 'togglApi', options);
 	} catch (error) {
 		throw new NodeApiError(this.getNode(), error as JsonObject);
 	}

diff --git a/packages/nodes-base/nodes/Toggl/TogglTrigger.node.ts b/packages/nodes-base/nodes/Toggl/TogglTrigger.node.ts
@@ -9,6 +9,7 @@ import type {
 import { NodeApiError, NodeOperationError } from 'n8n-workflow';
 
 import moment from 'moment-timezone';
+import { DateTime } from 'luxon';
 import { togglApiRequest } from './GenericFunctions';
 
 export class TogglTrigger implements INodeType {
@@ -62,7 +63,7 @@ export class TogglTrigger implements INodeType {
 
 		const qs: IDataObject = {};
 		let timeEntries = [];
-		qs.start_date = webhookData.lastTimeChecked;
+		qs.start_date = webhookData.lastTimeChecked ?? DateTime.now().toISODate();
 		qs.end_date = moment().format();
 
 		try {