add tests

n8n-io · Sep 5, 2023 · 9ff3b9b · 9ff3b9b
1 parent 5a9a254
commit 9ff3b9b
Show file tree

Hide file tree

Showing 3 changed files with 267 additions and 8 deletions.
diff --git a/packages/core/src/NodeExecuteFunctions.ts b/packages/core/src/NodeExecuteFunctions.ts
@@ -611,15 +611,15 @@ export function parseIncomingMessage(message: IncomingMessage) {
 		})();
 		message.contentType = contentType;
 		message.encoding = (parameters?.charset ?? 'utf-8').toLowerCase() as BufferEncoding;
+	}
 
-		const contentDispositionHeader = message.headers['content-disposition'];
-		if (contentDispositionHeader?.length) {
-			const {
-				type,
-				parameters: { filename },
-			} = parseContentDisposition(contentDispositionHeader);
-			message.contentDisposition = { type, filename };
-		}
+	const contentDispositionHeader = message.headers['content-disposition'];
+	if (contentDispositionHeader?.length) {
+		const {
+			type,
+			parameters: { filename },
+		} = parseContentDisposition(contentDispositionHeader);
+		message.contentDisposition = { type, filename };
 	}
 }
 

diff --git a/packages/nodes-base/nodes/HttpRequest/test/binaryData/HttpRequest.test.ts b/packages/nodes-base/nodes/HttpRequest/test/binaryData/HttpRequest.test.ts
@@ -0,0 +1,45 @@
+import nock from 'nock';
+import {
+	setup,
+	equalityTest,
+	workflowToTests,
+	getWorkflowFilenames,
+	initBinaryDataManager,
+} from '@test/nodes/Helpers';
+
+describe('Test Binary Data Download', () => {
+	const workflows = getWorkflowFilenames(__dirname);
+	const tests = workflowToTests(workflows);
+
+	const baseUrl = 'https://dummy.domain';
+
+	beforeAll(async () => {
+		await initBinaryDataManager();
+
+		nock.disableNetConnect();
+
+		nock(baseUrl)
+			.persist()
+			.get('/path/to/image.png')
+			.reply(200, Buffer.from('test'), { 'content-type': 'image/png' });
+
+		nock(baseUrl)
+			.persist()
+			.get('/redirect-to-image')
+			.reply(302, {}, { location: baseUrl + '/path/to/image.png' });
+
+		nock(baseUrl).persist().get('/custom-content-disposition').reply(200, Buffer.from('testing'), {
+			'content-disposition': 'attachment; filename="testing.jpg"',
+		});
+	});
+
+	afterAll(() => {
+		nock.restore();
+	});
+
+	const nodeTypes = setup(tests);
+
+	for (const testData of tests) {
+		test(testData.description, async () => equalityTest(testData, nodeTypes));
+	}
+});
diff --git a/packages/nodes-base/nodes/HttpRequest/test/binaryData/binaryData.test.json b/packages/nodes-base/nodes/HttpRequest/test/binaryData/binaryData.test.json
@@ -0,0 +1,214 @@
+{
+  "name": "Download as Binary Data",
+  "nodes": [
+    {
+      "name": "When clicking \"Execute Workflow\"",
+      "type": "n8n-nodes-base.manualTrigger",
+      "typeVersion": 1,
+      "parameters": {}
+    },
+    {
+      "name": "HTTP Request (v1)",
+      "type": "n8n-nodes-base.httpRequest",
+      "typeVersion": 1,
+      "parameters": {
+        "url": "https://dummy.domain/path/to/image.png",
+        "responseFormat": "file"
+      }
+    },
+    {
+      "name": "HTTP Request (v2)",
+      "type": "n8n-nodes-base.httpRequest",
+      "typeVersion": 2,
+      "parameters": {
+        "url": "https://dummy.domain/path/to/image.png",
+        "responseFormat": "file",
+        "options": {}
+      }
+    },
+    {
+      "name": "HTTP Request (v3)",
+      "type": "n8n-nodes-base.httpRequest",
+      "typeVersion": 3,
+      "parameters": {
+        "url": "https://dummy.domain/path/to/image.png",
+        "options": {
+          "response": {
+            "response": {
+              "responseFormat": "file"
+            }
+          }
+        }
+      }
+    },
+    {
+      "name": "HTTP Request (v4)",
+      "type": "n8n-nodes-base.httpRequest",
+      "typeVersion": 4,
+      "parameters": {
+        "url": "https://dummy.domain/path/to/image.png",
+        "options": {
+          "response": {
+            "response": {
+              "responseFormat": "file"
+            }
+          }
+        }
+      }
+    },
+    {
+      "name": "Follow Redirect",
+      "type": "n8n-nodes-base.httpRequest",
+      "typeVersion": 4.1,
+      "parameters": {
+        "url": "https://dummy.domain/redirect-to-image",
+        "options": {
+          "response": {
+            "response": {
+              "responseFormat": "file"
+            }
+          }
+        }
+      }
+    },
+    {
+      "name": "Content Disposition",
+      "type": "n8n-nodes-base.httpRequest",
+      "typeVersion": 4.1,
+      "parameters": {
+        "url": "https://dummy.domain/custom-content-disposition",
+        "options": {
+          "response": {
+            "response": {
+              "responseFormat": "file"
+            }
+          }
+        }
+      }
+    }
+  ],
+  "pinData": {
+    "HTTP Request (v1)": [
+      {
+        "binary": {
+          "data": {
+            "mimeType": "image/png",
+            "fileType": "image",
+            "fileExtension": "png",
+            "fileName": "image.png",
+            "fileSize": "4 B"
+          }
+        },
+        "json": {}
+      }
+    ],
+    "HTTP Request (v2)": [
+      {
+        "binary": {
+          "data": {
+            "mimeType": "image/png",
+            "fileType": "image",
+            "fileExtension": "png",
+            "fileName": "image.png",
+            "fileSize": "4 B"
+          }
+        },
+        "json": {}
+      }
+    ],
+    "HTTP Request (v3)": [
+      {
+        "binary": {
+          "data": {
+            "mimeType": "image/png",
+            "fileType": "image",
+            "fileExtension": "png",
+            "fileName": "image.png",
+            "fileSize": "4 B"
+          }
+        },
+        "json": {}
+      }
+    ],
+    "HTTP Request (v4)": [
+      {
+        "binary": {
+          "data": {
+            "mimeType": "image/png",
+            "fileType": "image",
+            "fileExtension": "png",
+            "fileName": "image.png",
+            "fileSize": "4 B"
+          }
+        },
+        "json": {}
+      }
+    ],
+    "Follow Redirect": [
+      {
+        "binary": {
+          "data": {
+            "mimeType": "image/png",
+            "fileType": "image",
+            "fileExtension": "png",
+            "fileName": "image.png",
+            "fileSize": "4 B"
+          }
+        },
+        "json": {}
+      }
+    ],
+    "Content Disposition": [
+      {
+        "binary": {
+          "data": {
+            "mimeType": "image/jpeg",
+            "fileType": "image",
+            "fileExtension": "jpg",
+            "fileName": "testing.jpg",
+            "fileSize": "7 B"
+          }
+        },
+        "json": {}
+      }
+    ]
+  },
+  "connections": {
+    "When clicking \"Execute Workflow\"": {
+      "main": [
+        [
+          {
+            "node": "HTTP Request (v1)",
+            "type": "main",
+            "index": 0
+          },
+          {
+            "node": "HTTP Request (v2)",
+            "type": "main",
+            "index": 0
+          },
+          {
+            "node": "HTTP Request (v3)",
+            "type": "main",
+            "index": 0
+          },
+          {
+            "node": "HTTP Request (v4)",
+            "type": "main",
+            "index": 0
+          },
+          {
+            "node": "Follow Redirect",
+            "type": "main",
+            "index": 0
+          },
+          {
+            "node": "Content Disposition",
+            "type": "main",
+            "index": 0
+          }
+        ]
+      ]
+    }
+  }
+}