fix: Remove node AI Transform node (no-changelog) (#10400)

n8n-io · Aug 14, 2024 · bae0116 · bae0116
1 parent c4fcbe4
commit bae0116
Show file tree

Hide file tree

Showing 23 changed files with 38 additions and 831 deletions.
diff --git a/packages/@n8n/nodes-langchain/nodes/trigger/ManualChatTrigger/ManualChatTrigger.node.ts b/packages/@n8n/nodes-langchain/nodes/trigger/ManualChatTrigger/ManualChatTrigger.node.ts
@@ -50,9 +50,7 @@ export class ManualChatTrigger implements INodeType {
 				name: 'openChat',
 				type: 'button',
 				typeOptions: {
-					buttonConfig: {
-						action: 'openChat',
-					},
+					action: 'openChat',
 				},
 				default: '',
 			},

diff --git a/packages/cli/src/controllers/dynamicNodeParameters.controller.ts b/packages/cli/src/controllers/dynamicNodeParameters.controller.ts
@@ -1,4 +1,4 @@
-import type { INodePropertyOptions, NodeParameterValueType } from 'n8n-workflow';
+import type { INodePropertyOptions } from 'n8n-workflow';
 
 import { Post, RestController } from '@/decorators';
 import { getBase } from '@/WorkflowExecuteAdditionalData';
@@ -92,28 +92,4 @@ export class DynamicNodeParametersController {
 			credentials,
 		);
 	}
-
-	@Post('/action-result')
-	async getActionResult(
-		req: DynamicNodeParametersRequest.ActionResult,
-	): Promise<NodeParameterValueType> {
-		const { currentNodeParameters, nodeTypeAndVersion, path, credentials, handler, payload } =
-			req.body;
-
-		const additionalData = await getBase(req.user.id, currentNodeParameters);
-
-		if (handler) {
-			return await this.service.getActionResult(
-				handler,
-				path,
-				additionalData,
-				nodeTypeAndVersion,
-				currentNodeParameters,
-				payload,
-				credentials,
-			);
-		}
-
-		return;
-	}
 }
diff --git a/packages/cli/src/requests.ts b/packages/cli/src/requests.ts
@@ -419,12 +419,6 @@ export declare namespace DynamicNodeParametersRequest {
 	type ResourceMapperFields = BaseRequest<{
 		methodName: string;
 	}>;
-
-	/** POST /dynamic-node-parameters/action-result */
-	type ActionResult = BaseRequest<{
-		handler: string;
-		payload: IDataObject | string | undefined;
-	}>;
 }
 
 // ----------------------------------

diff --git a/packages/cli/src/services/dynamicNodeParameters.service.ts b/packages/cli/src/services/dynamicNodeParameters.service.ts
@@ -15,8 +15,6 @@ import type {
 	INodeCredentials,
 	INodeParameters,
 	INodeTypeNameVersion,
-	NodeParameterValueType,
-	IDataObject,
 } from 'n8n-workflow';
 import { Workflow, RoutingNode, ApplicationError } from 'n8n-workflow';
 import { NodeExecuteFunctions } from 'n8n-core';
@@ -158,24 +156,6 @@ export class DynamicNodeParametersService {
 		return method.call(thisArgs);
 	}
 
-	/** Returns the result of the action handler */
-	async getActionResult(
-		handler: string,
-		path: string,
-		additionalData: IWorkflowExecuteAdditionalData,
-		nodeTypeAndVersion: INodeTypeNameVersion,
-		currentNodeParameters: INodeParameters,
-		payload: IDataObject | string | undefined,
-		credentials?: INodeCredentials,
-	): Promise<NodeParameterValueType> {
-		const nodeType = this.getNodeType(nodeTypeAndVersion);
-		const method = this.getMethod('actionHandler', handler, nodeType);
-		const workflow = this.getWorkflow(nodeTypeAndVersion, currentNodeParameters, credentials);
-		const thisArgs = this.getThisArg(path, additionalData, workflow);
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-return
-		return method.call(thisArgs, payload);
-	}
-
 	private getMethod(
 		type: 'resourceMapping',
 		methodName: string,
@@ -195,14 +175,9 @@ export class DynamicNodeParametersService {
 		methodName: string,
 		nodeType: INodeType,
 	): (this: ILoadOptionsFunctions) => Promise<INodePropertyOptions[]>;
-	private getMethod(
-		type: 'actionHandler',
-		methodName: string,
-		nodeType: INodeType,
-	): (this: ILoadOptionsFunctions, payload?: string) => Promise<NodeParameterValueType>;
 
 	private getMethod(
-		type: 'resourceMapping' | 'listSearch' | 'loadOptions' | 'actionHandler',
+		type: 'resourceMapping' | 'listSearch' | 'loadOptions',
 		methodName: string,
 		nodeType: INodeType,
 	) {

diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts
@@ -1553,11 +1553,6 @@ export declare namespace DynamicNodeParameters {
 	interface ResourceMapperFieldsRequest extends BaseRequest {
 		methodName: string;
 	}
-
-	interface ActionResultRequest extends BaseRequest {
-		handler: string;
-		payload: IDataObject | string | undefined;
-	}
 }
 
 export interface EnvironmentVariable {

diff --git a/packages/editor-ui/src/api/nodeTypes.ts b/packages/editor-ui/src/api/nodeTypes.ts
@@ -5,7 +5,6 @@ import type {
 	INodePropertyOptions,
 	INodeTypeDescription,
 	INodeTypeNameVersion,
-	NodeParameterValueType,
 	ResourceMapperFields,
 } from 'n8n-workflow';
 import axios from 'axios';
@@ -58,15 +57,3 @@ export async function getResourceMapperFields(
 		sendData,
 	);
 }
-
-export async function getNodeParameterActionResult(
-	context: IRestApiContext,
-	sendData: DynamicNodeParameters.ActionResultRequest,
-): Promise<NodeParameterValueType> {
-	return await makeRestApiRequest(
-		context,
-		'POST',
-		'/dynamic-node-parameters/action-result',
-		sendData,
-	);
-}