test: refactor

n8n-io · Nov 2, 2023 · c9e4f7f · c9e4f7f
1 parent 25fba3f
commit c9e4f7f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/editor-ui/src/stores/ui.store.ts b/packages/editor-ui/src/stores/ui.store.ts
@@ -37,7 +37,6 @@ import {
 	DEBUG_PAYWALL_MODAL_KEY,
 	N8N_PRICING_PAGE_URL,
 	WORKFLOW_HISTORY_VERSION_RESTORE,
-	LOCAL_STORAGE_THEME,
 } from '@/constants';
 import type {
 	CloudUpdateLinkSourceType,
@@ -67,15 +66,14 @@ import type { BannerName } from 'n8n-workflow';
 import {
 	addThemeToBody,
 	getPreferredTheme,
-	getQueryParam,
+	getThemeOverride,
 	isValidTheme,
 	updateTheme,
 } from './ui.utils';
 
 let savedTheme: ThemeOption = 'system';
 try {
-	// query param allows overriding theme for demo view in preview iframe without flickering
-	const value = getQueryParam('theme') || localStorage.getItem(LOCAL_STORAGE_THEME);
+	const value = getThemeOverride();
 	if (isValidTheme(value)) {
 		savedTheme = value;
 		addThemeToBody(value);

diff --git a/packages/editor-ui/src/stores/ui.utils.ts b/packages/editor-ui/src/stores/ui.utils.ts
@@ -9,7 +9,12 @@ export function isValidTheme(theme: string | null): theme is AppliedThemeOption
 	return !!theme && ['light', 'dark'].includes(theme);
 }
 
-export function getQueryParam(paramName: string): string | null {
+// query param allows overriding theme for demo view in preview iframe without flickering
+export function getThemeOverride() {
+	return getQueryParam('theme') || localStorage.getItem(LOCAL_STORAGE_THEME);
+}
+
+function getQueryParam(paramName: string): string | null {
 	return new URLSearchParams(window.location.search).get(paramName);
 }