-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(editor): Fix workflow card open action (#8839)
- Loading branch information
Showing
2 changed files
with
101 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
packages/editor-ui/src/components/__tests__/WorkflowCard.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
import type { MockInstance } from 'vitest'; | ||
import { setActivePinia, createPinia } from 'pinia'; | ||
import { waitFor, within } from '@testing-library/vue'; | ||
import userEvent from '@testing-library/user-event'; | ||
import { createComponentRenderer } from '@/__tests__/render'; | ||
import { VIEWS } from '@/constants'; | ||
import WorkflowCard from '@/components/WorkflowCard.vue'; | ||
|
||
const $router = { | ||
push: vi.fn(), | ||
resolve: vi.fn().mockImplementation(() => ({ href: '' })), | ||
}; | ||
|
||
const renderComponent = createComponentRenderer(WorkflowCard, { | ||
global: { | ||
mocks: { | ||
$router, | ||
}, | ||
}, | ||
}); | ||
|
||
const createWorkflow = (overrides = {}) => ({ | ||
id: '1', | ||
name: 'My Workflow', | ||
createdAt: '2021-01-01T00:00:00.000Z', | ||
...overrides, | ||
}); | ||
|
||
describe('WorkflowCard', () => { | ||
let pinia: ReturnType<typeof createPinia>; | ||
let windowOpenSpy: MockInstance; | ||
|
||
beforeEach(async () => { | ||
pinia = createPinia(); | ||
setActivePinia(pinia); | ||
windowOpenSpy = vi.spyOn(window, 'open'); | ||
}); | ||
|
||
afterEach(() => { | ||
vi.clearAllMocks(); | ||
}); | ||
|
||
it('should render a card with the workflow name and open workflow clicking on it', async () => { | ||
const data = createWorkflow(); | ||
const { getByRole } = renderComponent({ props: { data } }); | ||
const cardTitle = getByRole('heading', { level: 2, name: data.name }); | ||
|
||
expect(cardTitle).toBeInTheDocument(); | ||
|
||
await userEvent.click(cardTitle); | ||
await waitFor(() => { | ||
expect($router.push).toHaveBeenCalledWith({ | ||
name: VIEWS.WORKFLOW, | ||
params: { name: data.id }, | ||
}); | ||
}); | ||
|
||
// Opens in new tab if meta key is used | ||
const user = userEvent.setup(); | ||
|
||
await user.keyboard('[ControlLeft>]'); | ||
await user.click(cardTitle); | ||
await waitFor(() => { | ||
expect($router.push).toHaveBeenCalledTimes(1); | ||
}); | ||
expect(windowOpenSpy).toHaveBeenCalled(); | ||
}); | ||
|
||
it('should open card actions menu and not open workflow, open only on card action', async () => { | ||
const data = createWorkflow(); | ||
const { getByTestId } = renderComponent({ props: { data } }); | ||
const cardActions = getByTestId('workflow-card-actions'); | ||
|
||
expect(cardActions).toBeInTheDocument(); | ||
|
||
const cardActionsOpener = within(cardActions).getByRole('button'); | ||
expect(cardActionsOpener).toBeInTheDocument(); | ||
|
||
const controllingId = cardActionsOpener.getAttribute('aria-controls'); | ||
|
||
await userEvent.click(cardActions); | ||
await waitFor(() => { | ||
expect($router.push).not.toHaveBeenCalled(); | ||
}); | ||
|
||
const actions = document.querySelector(`#${controllingId}`); | ||
await waitFor(() => { | ||
expect(actions).toBeInTheDocument(); | ||
}); | ||
await userEvent.click(actions!.querySelectorAll('li')[0]); | ||
await waitFor(() => { | ||
expect($router.push).toHaveBeenCalledWith({ | ||
name: VIEWS.WORKFLOW, | ||
params: { name: data.id }, | ||
}); | ||
}); | ||
}); | ||
}); |