Apply suggestions from code review

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
n8n-io · Oct 20, 2023 · de02993 · de02993
1 parent 510284c
commit de02993
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/packages/cli/src/InternalHooks.ts b/packages/cli/src/InternalHooks.ts
@@ -57,7 +57,7 @@ export class InternalHooks implements IInternalHooksClass {
 		private roleService: RoleService,
 		private executionRepository: ExecutionRepository,
 		eventsService: EventsService,
-		private instanceSettings: InstanceSettings,
+		private readonly instanceSettings: InstanceSettings,
 	) {
 		eventsService.on('telemetry.onFirstProductionWorkflowSuccess', async (metrics) =>
 			this.onFirstProductionWorkflowSuccess(metrics),

diff --git a/packages/cli/src/License.ts b/packages/cli/src/License.ts
@@ -31,7 +31,7 @@ export class License {
 
 	private redisPublisher: RedisServicePubSubPublisher;
 
-	constructor(private instanceSettings: InstanceSettings) {
+	constructor(private readonly instanceSettings: InstanceSettings) {
 		this.logger = getLogger();
 	}
 

diff --git a/packages/cli/src/commands/start.ts b/packages/cli/src/commands/start.ts
@@ -282,10 +282,10 @@ export class Start extends BaseCommand {
 		if (flags.tunnel) {
 			this.log('\nWaiting for tunnel ...');
 
-			let tunnelSubdomain = process.env.N8N_TUNNEL_SUBDOMAIN ?? '';
-			tunnelSubdomain = tunnelSubdomain || this.instanceSettings.tunnelSubdomain || '';
+			let tunnelSubdomain =
+				process.env.N8N_TUNNEL_SUBDOMAIN ?? this.instanceSettings.tunnelSubdomain ?? '';
 
-			if (!tunnelSubdomain) {
+			if (tunnelSubdomain === '') {
 				// When no tunnel subdomain did exist yet create a new random one
 				const availableCharacters = 'abcdefghijklmnopqrstuvwxyz0123456789';
 				tunnelSubdomain = Array.from({ length: 24 })

diff --git a/packages/cli/src/posthog/index.ts b/packages/cli/src/posthog/index.ts
@@ -9,7 +9,7 @@ import type { PublicUser } from '@/Interfaces';
 export class PostHogClient {
 	private postHog?: PostHog;
 
-	constructor(private instanceSettings: InstanceSettings) {}
+	constructor(private readonly instanceSettings: InstanceSettings) {}
 
 	async init() {
 		const enabled = config.getEnv('diagnostics.enabled');

diff --git a/packages/cli/src/telemetry/index.ts b/packages/cli/src/telemetry/index.ts
@@ -40,7 +40,7 @@ export class Telemetry {
 	constructor(
 		private postHog: PostHogClient,
 		private license: License,
-		private instanceSettings: InstanceSettings,
+		private readonly instanceSettings: InstanceSettings,
 	) {}
 
 	async init() {

diff --git a/packages/core/src/Cipher.ts b/packages/core/src/Cipher.ts
@@ -4,7 +4,7 @@ import { InstanceSettings } from './InstanceSettings';
 
 @Service()
 export class Cipher {
-	constructor(private instanceSettings: InstanceSettings) {}
+	constructor(private readonly instanceSettings: InstanceSettings) {}
 
 	encrypt(data: string) {
 		return AES.encrypt(data, this.instanceSettings.encryptionKey).toString();

diff --git a/packages/core/src/NodeExecuteFunctions.ts b/packages/core/src/NodeExecuteFunctions.ts
@@ -2510,7 +2510,7 @@ const getCommonWorkflowFunctions = (
 
 	getRestApiUrl: () => additionalData.restApiUrl,
 	getInstanceBaseUrl: () => additionalData.instanceBaseUrl,
-	getInstanceId: async () => Container.get(InstanceSettings).instanceId,
+	getInstanceId: () => Container.get(InstanceSettings).instanceId,
 	getTimezone: () => getTimezone(workflow, additionalData),
 
 	prepareOutputData: async (outputData) => [outputData],
@@ -2616,7 +2616,7 @@ function isFilePathBlocked(filePath: string): boolean {
 	//restrict access to .n8n folder and other .env config related paths
 	if (blockFileAccessToN8nFiles) {
 		const { n8nFolder } = Container.get(InstanceSettings);
-		const restrictedPaths: string[] = [n8nFolder];
+		const restrictedPaths = [n8nFolder];
 
 		if (process.env[CONFIG_FILES]) {
 			restrictedPaths.push(...process.env[CONFIG_FILES].split(','));

diff --git a/packages/node-dev/commands/build.ts b/packages/node-dev/commands/build.ts
@@ -18,7 +18,7 @@ export class Build extends Command {
 		help: flags.help({ char: 'h' }),
 		destination: flags.string({
 			char: 'd',
-			description: `The path to copy the compiles files to [default: ${
+			description: `The path to copy the compiled files to [default: ${
 				Container.get(InstanceSettings).customExtensionDir
 			}]`,
 		}),

diff --git a/packages/workflow/test/Helpers.ts b/packages/workflow/test/Helpers.ts
@@ -43,11 +43,11 @@ export interface INodeTypesObject {
 }
 
 export class Credentials extends ICredentials {
-	hasNodeAccess(): boolean {
+	hasNodeAccess() {
 		return true;
 	}
 
-	setData(data: ICredentialDataDecryptedObject): void {
+	setData(data: ICredentialDataDecryptedObject) {
 		this.data = JSON.stringify(data);
 	}