Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Restore log event n8n.workflow.failed #10253

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 31, 2024

Summary

Accidentally removed here while disentangling event bus from internal hooks.

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/recent-updates-to-n8n-fail-to-send-n8n-workflow-failed-events-over-log-streaming/50984

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@ivov ivov added the release/backport Changes that need to be backported to older releases. label Jul 31, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 31, 2024
@ivov ivov requested a review from tomi July 31, 2024 09:55
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

cypress bot commented Jul 31, 2024



Test summary

390 0 0 0Flakiness 0


Run details

Project n8n
Status Passed
Commit bfd340a
Started Jul 31, 2024 10:17 AM
Ended Jul 31, 2024 10:22 AM
Duration 04:40 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 3e96b29 into master Jul 31, 2024
36 checks passed
@ivov ivov deleted the restore-log-event-n8n.workflow.failed branch July 31, 2024 10:22
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.52.2

@github-actions github-actions bot mentioned this pull request Jul 31, 2024
MiloradFilipovic added a commit that referenced this pull request Jul 31, 2024
* master:
  feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270)
  fix: Loop node no input data shown (#10224)
  fix(core): Make OAuth1/OAuth2 callback not require auth (#10263)
  🚀 Release 1.53.0 (#10266)
  fix(core): Upgrade @n8n/vm2 to address CVE‑2023‑37466 (#10265)
  feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251)
  test(core): Improve and expand log streaming tests (no-changelog) (#10261)
  refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198)
  fix(core): Restore log event `n8n.workflow.failed` (#10253)
  test(core): Stop showing JWT warning during test runs (no-changelog) (#10255)
MiloradFilipovic added a commit that referenced this pull request Aug 1, 2024
* master:
  refactor(core): Decouple workflow created, saved, deleted events from internal hooks (no-changelog) (#10264)
  fix(core): Fix oauth2 callback and add integration tests (no-changelog) (#10272)
  fix(n8n Form Trigger Node): Improve copy and a few tweaks (no-changelog) (#10243)
  fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data (#10247)
  refactor(core): Port endpoints config (no-changelog) (#10268)
  feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270)
  fix: Loop node no input data shown (#10224)
  fix(core): Make OAuth1/OAuth2 callback not require auth (#10263)
  🚀 Release 1.53.0 (#10266)
  fix(core): Upgrade @n8n/vm2 to address CVE‑2023‑37466 (#10265)
  feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251)
  test(core): Improve and expand log streaming tests (no-changelog) (#10261)
  refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198)
  fix(core): Restore log event `n8n.workflow.failed` (#10253)
  test(core): Stop showing JWT warning during test runs (no-changelog) (#10255)
  fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217)
  fix(editor): Fix workflow execution list scrolling after filter change (#10226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants