fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation #10217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShireenMissi
changed the title
n8n-assistant
bot
added
n8n team
ShireenMissi
changed the title
michael-radency
requested changes
Jul 30, 2024
There was a problem hiding this comment.
@ShireenMissi
LGTM, but since we are changing logic here and to avoid potentially breaking existing workflows I would suggest to put this change under minor version and to extract code into utils
packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts
Outdated
Show resolved
Hide resolved
michael-radency
approved these changes
Jul 31, 2024
packages/nodes-base/nodes/Postgres/v2/actions/database/executeQuery.operation.ts
Show resolved
Hide resolved
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 1, 2024
* master: refactor(core): Decouple workflow created, saved, deleted events from internal hooks (no-changelog) (#10264) fix(core): Fix oauth2 callback and add integration tests (no-changelog) (#10272) fix(n8n Form Trigger Node): Improve copy and a few tweaks (no-changelog) (#10243) fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data (#10247) refactor(core): Port endpoints config (no-changelog) (#10268) feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270) fix: Loop node no input data shown (#10224) fix(core): Make OAuth1/OAuth2 callback not require auth (#10263) 🚀 Release 1.53.0 (#10266) fix(core): Upgrade @n8n/vm2 to address CVE‑2023‑37466 (#10265) feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251) test(core): Improve and expand log streaming tests (no-changelog) (#10261) refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198) fix(core): Restore log event `n8n.workflow.failed` (#10253) test(core): Stop showing JWT warning during test runs (no-changelog) (#10255) fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217) fix(editor): Fix workflow execution list scrolling after filter change (#10226)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes using expressions in query parameters for Postgres executeQuery operation, the query parameters field is expected as comma separated string or an expression that can be evaluated to a comma separated string.
the issue was splitting based on ' , ' before evaluating the expression.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1431/postgres-expressions-in-query-params-broken
https://community.n8n.io/t/postgres-node-in-operator-with-parameters/47801/9
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)