Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI glitch - Trying to select multiple lines in Code Editor results in a close by accident #1353

Closed
ixidion opened this issue Jan 18, 2021 · 2 comments

Comments

@ixidion
Copy link

ixidion commented Jan 18, 2021

Describe the bug
The Code Editor closes too often by accident when marking multiples lines while holding the mouse button and releasing it outside the code editor.

To Reproduce
Steps to reproduce the behavior:

  1. Create a node, e.g. FunctionItem
  2. Click in the Code Editor and wait for popup to open.
  3. type some lines
  4. mark these lines with the mouse and still hold left mousebutton.
  5. Leave with mouse button pressed the code window and release the button
  6. Code Editor window closes

Expected behavior
Code window should stay open. Close should happen with either pressing the "X" or hitting 'ESC'.

Environment (please complete the following information):

  • OS: Debian 10 with Docker
  • n8n Version 0.101.0
  • Node.js Version 12.19
@janober
Copy link
Member

janober commented Jan 19, 2021

Thanks a lot for reporting this.

I am actually OK with closing the editor in the case somebody clicks outside of it. The problem here is really that it also closes it on releasing the button, and that should not happen. Is esp. annoying when selecting code (as you mentioned). As I did not find a way to easily fix that specific behavior did I now deactivate close on click as you proposed. Will be released with the next version.

@janober janober closed this as completed Jan 19, 2021
@janober
Copy link
Member

janober commented Jan 21, 2021

Got released with n8n@0.103.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants