-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Drive Node Sharing Notifications and UI options not working as expected #1354
Comments
@Adrian-Samuel thanks for explaining this so clearly. @ivov Just fixed it. We will let you know when is released. About the
|
Fix got now merged with #1354 and will be merged with the next version. |
Got released with n8n@0.104.0 |
I just upgraded, unfortunately, I think this node is broken now!
This flow doesn't work. There's a successful execution but no JSON response, and subsequently, the email that it's shared to not only now doesn't receive the email notification but it also doesn't get shared at all |
@Adrian-Samuel I'll test closely tomorrow, but this might be due to the previous node being disabled. Click on the Play button to enable. Update: Thank you for reporting this. Two separate changes were made in parallel to this node recently: this param fix and the drive resource addition. The merge introduced a condition that never evaluates to true, causing the share and delete options to now fail. We'll let you know as soon as it's fixed. |
Problem:
Essentially, I'm using the Google Drive node to share a given google sheet to a specific user via their email address.
In the n8n Drive node I select the options to send a notification email to the recipient the document is being shared to but unfortunately this option does not seem to work (and can sometimes throw buggy error messages about a boolean toggle option being blank when executed).
A fuller description of these problems below:
The buggy boolean error message can be seen here:
The way to overcome this error is to toggle the send notification on and off again and mostly it goes away...Though it makes me afraid of the presence of random errors when the flow is automated. - This is one bug
The export of this flow looks like this:
Note that on the options.sendNotificationEmail the option is sent to an empty string even though it is clearly a "true" boolean in the n8n UI as seen by the above-accompanied screenshot.
To test this out properly, I would suggest manually setting up the Node in the UI so you get a feel of where and how the error occurs.
Bug 2:
The document (the google sheet in this case) gets shared but the notification email or assigned message along with that notification doesn't get sent - this is the second bug.
This is the JSON of this flow:
More of a feature request:
Since the node doesn't have the "allowFileDiscovery" boolean option to make it searchable via the google sheets UI. You have to foreknow the URL to access and know it's been shared to you...which is additionally problematic if you're using this flow for teamwork. - This is more of a feature request but would sit nicely together with the above bug fixes.
I saw this boolean option here:
https://developers.google.com/drive/api/v3/reference/files/update
Happy to answer any additional questions about this!
The text was updated successfully, but these errors were encountered: