feat(editor): Ask AI #6672

OlegIvaniv · 2023-07-17T12:28:38Z

Refactor Code Editor into tabs if Ask AI is enabled
Refactor schema generators into composable and add methods to get input data with pinner
Replace code with generated and show alert if overriding
Remove the previous Ask AI fakedoor experiment

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

…-in-the-code-node

codecov · 2023-07-17T12:47:57Z

Codecov Report

Patch coverage: 73.85% and project coverage change: +0.20% 🎉

Comparison is base (6c60763) 24.86% compared to head (0170368) 25.06%.
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6672      +/-   ##
==========================================
+ Coverage   24.86%   25.06%   +0.20%     
==========================================
  Files        3144     3149       +5     
  Lines      191225   191880     +655     
  Branches    21096    21104       +8     
==========================================
+ Hits        47546    48096     +550     
- Misses     142698   142803     +105     
  Partials      981      981

Files Changed	Coverage Δ
packages/cli/src/Server.ts	`0.00% <ø> (ø)`
packages/cli/src/config/index.ts	`43.90% <ø> (ø)`
packages/cli/src/config/schema.ts	`37.50% <ø> (ø)`
...components/N8nCircleLoader/CircleLoader.stories.ts	`0.00% <0.00%> (ø)`
packages/editor-ui/src/components/Modals.vue	`0.00% <ø> (ø)`
packages/editor-ui/src/utils/typesUtils.ts	`52.79% <ø> (-9.59%)`	⬇️
packages/workflow/src/Interfaces.ts	`57.14% <ø> (ø)`
packages/editor-ui/src/plugins/telemetry/index.ts	`30.28% <14.28%> (-0.83%)`	⬇️
packages/editor-ui/src/api/ai.ts	`29.41% <29.41%> (ø)`
...i/src/components/CodeNodeEditor/CodeNodeEditor.vue	`39.79% <43.60%> (+0.96%)`	⬆️
... and 11 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

…og) (#6675) fix: remove duplicate source control preferences fetching (no-changelog)

…-changelog) (#6668) fix(Slack Node): Add UTM params to n8n reference in Slack message

…plying (#6583)

…ta (#6680) deleting manual executions should defer deleting binary data

* fix(editor): Add paywall state to non owner users for Variables * fix(editor): Add variables view tests * fix(editor): remove link from paywall state for non owner * fix(editor): fix displaying logic

refactor(core): Refactor WorkflowStatistics code

…rkflow form a template (#6671)

* fix(core): Upgrade semver to address CVE-2022-25883 [GH Advisory](GHSA-c2qf-rxjj-qqgw) * enforce the patched version of semver everywhere in the dev setup

ci: Fix test checker glob

* fix(API): Do not add starting node on workflow creation * chore: Remove comment

…6676) * fix(core): Deactivate on init workflow that should not be retried * fix(core): Filter out workflows with activation errors

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

…he-code-node

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

cypress · 2023-08-14T11:45:17Z

Passing run #1880 ↗︎

0	226	0	0	0

Details:

🌳 ado-610-fe-ai-powered-code-generation-in-the-code-node 🖥️ browsers:node18.12...
Project: n8n	Commit: `0170368ab2`
Status: Passed	Duration: 07:43 💡
Started: Aug 16, 2023 9:24 AM	Ended: Aug 16, 2023 9:31 AM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

packages/editor-ui/src/components/CodeNodeEditor/CodeNodeEditor.vue

packages/editor-ui/src/components/CodeNodeEditor/AskAI/CircleLoader.vue

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

…he-code-node

OlegIvaniv · 2023-08-15T18:53:29Z

@mutdmour Thanks for the thorough review! I've addressed your comments. Can you have another look, please?

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

mutdmour · 2023-08-16T09:15:10Z

packages/editor-ui/src/n8n-theme.scss

@@ -128,6 +128,30 @@
 	font-weight: bold;
 }

+.el-tabs__content {


I meant tabs.scss before.. since our theme lives there.. but this is fine for now

mutdmour · 2023-08-16T09:16:20Z

packages/editor-ui/src/components/CodeNodeEditor/CodeNodeEditor.vue

-				(this.posthogStore.getVariant(ASK_AI_EXPERIMENT.name) ?? ASK_AI_EXPERIMENT.control) ===
-				ASK_AI_EXPERIMENT.control;
+			const isAiExperimentEnabled = [ASK_AI_EXPERIMENT.gpt3, ASK_AI_EXPERIMENT.gpt4].includes(
+				(this.posthogStore.getVariant(ASK_AI_EXPERIMENT.name) ?? '') as string,


is as string needed?

Yes, because getVariant return types are boolean | string | undefined

ideally we would avoid type casting..

github-actions · 2023-08-16T09:31:59Z

✅ All Cypress E2E specs passed

# [1.3.0](https://github.com/n8n-io/n8n/compare/n8n@1.2.0...n8n@1.3.0) (2023-08-16) ### Bug Fixes * **core:** Don't let bull override the default redis config ([#6897](#6897)) ([cfeb322](cfeb322)) * **core:** Fix fetching of EE executions ([#6901](#6901)) ([f3fce48](f3fce48)) * **core:** Update frontend urls when using the `--tunnel` option ([#6898](#6898)) ([718e613](718e613)) * **editor:** Disable telemetry in dev mode and in E2E tests ([#6869](#6869)) ([808a928](808a928)) * **editor:** Fix code node’s content property to be reactive ([#6931](#6931)) ([3b75bc6](3b75bc6)) * **editor:** Fix event emit on credential sharing ([#6922](#6922)) ([297c3c9](297c3c9)) * **editor:** Fix multiOptions parameters resetting on initial load ([#6903](#6903)) ([49867c2](49867c2)) * **editor:** Update execution view layout ([#6882](#6882)) ([0339732](0339732)) * **Email Trigger (IMAP) Node:** Fix connection issue with unexpected spaces in host ([#6886](#6886)) ([f3248e4](f3248e4)) * Fix issue with key formatting if null or undefined ([#6924](#6924)) ([4e4a3cf](4e4a3cf)) * Fix issue with key formatting introduced in 1.2.0 ([#6896](#6896)) ([0e075c9](0e075c9)) * Fix lag when node parameters are updated ([#6941](#6941)) ([3eb65e0](3eb65e0)) * **HTTP Request Node:** Improve error handling for TCP socket errors when `Continue On Fail` is enabled ([#6925](#6925)) ([96ff1f8](96ff1f8)) * Prevent workflow breaking when credential type is unknown ([#6923](#6923)) ([e83b93f](e83b93f)) * **Respond to Webhook Node:** Return headers in response ([#6921](#6921)) ([a82107f](a82107f)) ### Features * **core:** Add support for not requiring SMTP auth with user management ([#3742](#3742)) ([eead6d4](eead6d4)) * **core:** Descriptive message for common nodeJS errors ([#6841](#6841)) ([3adb0b6](3adb0b6)) * **editor:** Ask AI in Code node ([#6672](#6672)) ([fde6ad1](fde6ad1)) * Enable parallel processing on multiple queue nodes ([#6295](#6295)) ([44afcff](44afcff)) Co-authored-by: netroy <netroy@users.noreply.github.com>

OlegIvaniv added 2 commits July 17, 2023 14:26

feat(editor): Ask AI tab and CLi connection

32eb324

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Merge branch 'ask-ai-code' into ado-610-fe-ai-powered-code-generation…

c932c91

…-in-the-code-node

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 17, 2023

OlegIvaniv added 5 commits July 17, 2023 14:54

Remove old getSchema util method

fca2b52

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Increase CSS specificity of the CodeNodeEditor global overrides

f1c3b8a

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

feat(editor): Magic Connect

c8d84ba

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Improve AI controller, load conditionally, UX modal imporvements

d01439a

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Extract-out AI curl

0e39fee

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

OlegIvaniv force-pushed the ado-610-fe-ai-powered-code-generation-in-the-code-node branch from 6ea3ba4 to 0e39fee Compare July 25, 2023 15:26

OlegIvaniv and others added 18 commits July 26, 2023 09:43

Move loading phrases to locale, add support for ask ai experiment

88628a7

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

fix build

6215d97

adjust communication

96bd0d4

fix: Remove duplicate source control preferences fetching (no-changel…

3341217

…og) (#6675) fix: remove duplicate source control preferences fetching (no-changelog)

fix(Slack Node): Add UTM params to n8n reference in Slack message (no…

535dc97

…-changelog) (#6668) fix(Slack Node): Add UTM params to n8n reference in Slack message

fix(FileMaker Node): Improve returned error responses (#6585)

67752a6

fix(Microsoft Outlook Node): Fix issue with category not correctly ap…

2a75136

…plying (#6583)

feat(Airtable Node): Overhaul (#6200)

7e21d6c

fix(core): Deleting manual executions should defer deleting binary da…

949937d

…ta (#6680) deleting manual executions should defer deleting binary data

fix(editor): Add paywall state to non owner users for Variables (#6679)

64b48a2

* fix(editor): Add paywall state to non owner users for Variables * fix(editor): Add variables view tests * fix(editor): remove link from paywall state for non owner * fix(editor): fix displaying logic

refactor(core): Refactor WorkflowStatistics code (no-changelog) (#6617)

551b9a8

refactor(core): Refactor WorkflowStatistics code

fix(editor): Hide Execute Node button for unknown nodes (#6684)

3a672b9

feat: Allow hiding credential params on cloud (#6687)

e0cc835

fix: Stop n8n from complaining about credentials when saving a new wo…

cfc25ec

…rkflow form a template (#6671)

fix(core): Upgrade semver to address CVE-2022-25883 (#6689)

89998ff

* fix(core): Upgrade semver to address CVE-2022-25883 [GH Advisory](GHSA-c2qf-rxjj-qqgw) * enforce the patched version of semver everywhere in the dev setup

ci: Fix test checker glob (no changelog) (#6682)

d8eac09

ci: Fix test checker glob

fix(API): Do not add starting node on workflow creation (#6686)

8a67978

* fix(API): Do not add starting node on workflow creation * chore: Remove comment

fix(core): Filter out workflows that failed to activate on startup (#…

34e1a1b

…6676) * fix(core): Deactivate on init workflow that should not be retried * fix(core): Filter out workflows with activation errors

OlegIvaniv added 12 commits August 8, 2023 15:20

Address review points

8ca6ba4

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Optionally access total_tokens

af1b403

Clean-up Ask AI modal

d480095

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Store prompt in sessionStorage

f7b30ee

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Improve schema generation, only get parent nodes

c728b33

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Send error messages to telemetry, aske before switching tabs

0f9ae7b

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Add locale

ad8477d

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Merge branch 'master' into ado-610-fe-ai-powered-code-generation-in-t…

7c60c87

…he-code-node

Post-merge cleanup

2bce33e

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Move Ask AI into separate folder

c7b7cc9

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Lint fix

7b021b5

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Constants lint fix

24d2cf3

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

OlegIvaniv changed the title ~~feat(editor): Ask AI tab and CLi connection~~ feat(editor): Ask AI Aug 14, 2023

Add Ask AI e2e tests and fix linting issues

4531622

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

mutdmour reviewed Aug 15, 2023

View reviewed changes

OlegIvaniv added 4 commits August 15, 2023 18:32

Move CircleLoader to design-lib

b50a92d

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Replace circle-lodaer and move el-tabs styles to n8n theme

6adc5d9

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Fix placeholder & e2e tests

59fdf98

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

Merge branch 'master' into ado-610-fe-ai-powered-code-generation-in-t…

ad573da

…he-code-node

OlegIvaniv requested a review from mutdmour August 15, 2023 18:53

Remove old CircleLoader

0170368

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>

mutdmour reviewed Aug 16, 2023

View reviewed changes

mutdmour approved these changes Aug 16, 2023

View reviewed changes

OlegIvaniv merged commit fde6ad1 into master Aug 16, 2023
24 checks passed

OlegIvaniv deleted the ado-610-fe-ai-powered-code-generation-in-the-code-node branch August 16, 2023 11:08

github-actions bot mentioned this pull request Aug 16, 2023

🚀 Release 1.3.0 #6945

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(editor): Ask AI #6672

feat(editor): Ask AI #6672

OlegIvaniv commented Jul 17, 2023 •

edited

Loading

codecov bot commented Jul 17, 2023 •

edited

Loading

cypress bot commented Aug 14, 2023 •

edited

Loading

OlegIvaniv commented Aug 15, 2023

mutdmour Aug 16, 2023

mutdmour Aug 16, 2023

OlegIvaniv Aug 16, 2023

mutdmour Aug 16, 2023

github-actions bot commented Aug 16, 2023

feat(editor): Ask AI #6672

feat(editor): Ask AI #6672

Conversation

OlegIvaniv commented Jul 17, 2023 • edited Loading

codecov bot commented Jul 17, 2023 • edited Loading

Codecov Report

cypress bot commented Aug 14, 2023 • edited Loading

Passing run #1880 ↗︎

OlegIvaniv commented Aug 15, 2023

mutdmour Aug 16, 2023

Choose a reason for hiding this comment

mutdmour Aug 16, 2023

Choose a reason for hiding this comment

OlegIvaniv Aug 16, 2023

Choose a reason for hiding this comment

mutdmour Aug 16, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 16, 2023

OlegIvaniv commented Jul 17, 2023 •

edited

Loading

codecov bot commented Jul 17, 2023 •

edited

Loading

cypress bot commented Aug 14, 2023 •

edited

Loading