feat: Add support for not requiring SMTP auth with user management #3742

xavier-calland · 2022-07-20T13:42:05Z

do not check for user/pass in isEmailSetUp
do not pass an "auth" property to nodemailer if no user/pass

- do not check for user/pass in isEmailSetUp - do not pass an "auth" property to nodemailer if no user/pass Issue: n8n-io#3740

CLAassistant · 2022-07-20T13:42:14Z

All committers have signed the CLA.

nathanael-h · 2022-09-01T07:48:11Z

Hello, on my server there is an SMTP which does not requiere auth when reached internally (via localhost or 127.0.0.1). I think this PR could fix the issue I have (YunoHost-Apps/n8n_ynh#30). If I try to build and test this PR, would this help?

github-actions · 2023-08-14T14:31:38Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

codecov · 2023-08-14T15:20:12Z

Codecov Report

Patch coverage: 20.00% and project coverage change: +0.01% 🎉

Comparison is base (a82107f) 24.85% compared to head (0f38e40) 24.86%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3742      +/-   ##
==========================================
+ Coverage   24.85%   24.86%   +0.01%     
==========================================
  Files        3144     3144              
  Lines      191241   191258      +17     
  Branches    21089    21095       +6     
==========================================
+ Hits        47528    47552      +24     
+ Misses     142735   142725      -10     
- Partials      978      981       +3

Files Changed	Coverage Δ
...ackages/cli/src/UserManagement/email/NodeMailer.ts	`11.11% <0.00%> (-1.02%)`	⬇️
...ges/cli/src/UserManagement/UserManagementHelper.ts	`78.88% <100.00%> (-0.46%)`	⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Joffcom · 2023-08-14T15:35:12Z

Hey @xavier-calland,

Thanks for the PR and sorry for the delay, I am planning on getting this merged shortly.

packages/cli/src/UserManagement/email/NodeMailer.ts

Change implemented

# [1.3.0](https://github.com/n8n-io/n8n/compare/n8n@1.2.0...n8n@1.3.0) (2023-08-16) ### Bug Fixes * **core:** Don't let bull override the default redis config ([#6897](#6897)) ([cfeb322](cfeb322)) * **core:** Fix fetching of EE executions ([#6901](#6901)) ([f3fce48](f3fce48)) * **core:** Update frontend urls when using the `--tunnel` option ([#6898](#6898)) ([718e613](718e613)) * **editor:** Disable telemetry in dev mode and in E2E tests ([#6869](#6869)) ([808a928](808a928)) * **editor:** Fix code node’s content property to be reactive ([#6931](#6931)) ([3b75bc6](3b75bc6)) * **editor:** Fix event emit on credential sharing ([#6922](#6922)) ([297c3c9](297c3c9)) * **editor:** Fix multiOptions parameters resetting on initial load ([#6903](#6903)) ([49867c2](49867c2)) * **editor:** Update execution view layout ([#6882](#6882)) ([0339732](0339732)) * **Email Trigger (IMAP) Node:** Fix connection issue with unexpected spaces in host ([#6886](#6886)) ([f3248e4](f3248e4)) * Fix issue with key formatting if null or undefined ([#6924](#6924)) ([4e4a3cf](4e4a3cf)) * Fix issue with key formatting introduced in 1.2.0 ([#6896](#6896)) ([0e075c9](0e075c9)) * Fix lag when node parameters are updated ([#6941](#6941)) ([3eb65e0](3eb65e0)) * **HTTP Request Node:** Improve error handling for TCP socket errors when `Continue On Fail` is enabled ([#6925](#6925)) ([96ff1f8](96ff1f8)) * Prevent workflow breaking when credential type is unknown ([#6923](#6923)) ([e83b93f](e83b93f)) * **Respond to Webhook Node:** Return headers in response ([#6921](#6921)) ([a82107f](a82107f)) ### Features * **core:** Add support for not requiring SMTP auth with user management ([#3742](#3742)) ([eead6d4](eead6d4)) * **core:** Descriptive message for common nodeJS errors ([#6841](#6841)) ([3adb0b6](3adb0b6)) * **editor:** Ask AI in Code node ([#6672](#6672)) ([fde6ad1](fde6ad1)) * Enable parallel processing on multiple queue nodes ([#6295](#6295)) ([44afcff](44afcff)) Co-authored-by: netroy <netroy@users.noreply.github.com>

janober · 2023-08-16T16:27:36Z

Got released with n8n@1.3.0

…3742)

# [0.237.0](https://github.com/n8n-io/n8n/compare/n8n@0.236.3...n8n@0.237.0) (2023-08-17) ### Bug Fixes * **API:** Fix issue with workflow setting not supporting newer nanoids ([#6699](#6699)) ([2e64c9d](2e64c9d)) * **AwsS3 Node:** Fix issue if bucket name contains a '.' ([#6542](#6542)) ([219f897](219f897)) * **core:** Add missing primary key on the `execution_data` table on postgres ([#6797](#6797)) ([1c5f98d](1c5f98d)) * **core:** Fix `continueOnFail` for expression error in Set ([#6939](#6939)) ([2a3937f](2a3937f)) * **core:** Fix property existence checks on AugmentObject ([#6842](#6842)) ([3e4483a](3e4483a)) * **core:** Log crash causes to console when sentry is disabled ([#6890](#6890)) ([f19c9c1](f19c9c1)) * **core:** Restrict read/write file paths access ([#6582](#6582)) ([6e6b90e](6e6b90e)) * **core:** Serialize BigInts ([#6805](#6805)) ([17ce49b](17ce49b)) * **core:** Update frontend urls when using the `--tunnel` option ([#6898](#6898)) ([ec3c066](ec3c066)) * **core:** Update packages to address CVE-2023-2142 and CVE-2020-28469 ([#6844](#6844)) ([6dd0850](6dd0850)) * Correct typos in Taiga and ServiceNow nodes ([#6814](#6814)) ([b9f52ec](b9f52ec)) * **editor:** Fix code node’s content property to be reactive ([#6931](#6931)) ([f3b380d](f3b380d)) * **editor:** Prevent Code node linter from erroring on `null` parse ([#6934](#6934)) ([baada92](baada92)) * **Email Trigger (IMAP) Node:** UTF-8 attachments are not correctly named ([#6856](#6856)) ([f3f1c14](f3f1c14)) * **Email Trigger (IMAP) Node:** Fix connection issue with unexpected spaces in host ([#6886](#6886)) ([35c29ac](35c29ac)) * Fix issue with key based credentials not being read correctly ([#6824](#6824)) ([2459b0a](2459b0a)) * Fix issue with key formatting if null or undefined ([#6924](#6924)) ([59d33db](59d33db)) * Fix issue with key formatting introduced in 1.2.0 ([#6896](#6896)) ([8423153](8423153)) * **FTP Node:** List recursive ignore . and .. to prevent infinite loops ([#6707](#6707)) ([6a787dd](6a787dd)) * **GitLab Trigger Node:** Fix trigger activation 404 error ([#6711](#6711)) ([8c5145b](8c5145b)) * **Gmail Trigger Node:** Early returns in case of no data ([#6727](#6727)) ([df2f1d6](df2f1d6)) * **Google BigQuery Node:** Error description improvement ([#6715](#6715)) ([261d73e](261d73e)) * **GoToWebinar Node:** Fix issue with timezone incorrectly being required ([#6865](#6865)) ([2f61e34](2f61e34)) * **HTTP Request Node:** Improve error handling for TCP socket errors when `Continue On Fail` is enabled ([#6925](#6925)) ([e8e4c9e](e8e4c9e)) * **Lemlist Node:** Fix pagination issues with campaigns and activities ([#6734](#6734)) ([73eddc6](73eddc6)) * **Salesforce Node:** Fix Account update owner operation ([#6958](#6958)) ([e71ff76](e71ff76)) * **Telegram Trigger Node:** Add guard to 'include' call on null or undefined ([#6730](#6730)) ([c3c845c](c3c845c)) * **Todoist Node:** Fix issue with section id being ignored ([#6799](#6799)) ([e53f4a0](e53f4a0)) ### Features * Add support for not requiring SMTP auth with user management ([#3742](#3742)) ([fc97d18](fc97d18)) * **core:** Add support for ready hooks, and credentials overwrite endpoint in workers ([#6954](#6954)) ([e5986c5](e5986c5)) * **editor:** Add "Download" button if JSON data is to large ([#6850](#6850)) ([3d815cf](3d815cf)) * Enable parallel processing on multiple queue nodes ([#6295](#6295)) ([e45461a](e45461a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

Allow SMTP configuration without auth

e280574

- do not check for user/pass in isEmailSetUp - do not pass an "auth" property to nodemailer if no user/pass Issue: n8n-io#3740

n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui labels Jul 20, 2022

nathanael-h mentioned this pull request Aug 27, 2022

SMTP integration YunoHost-Apps/n8n_ynh#30

Closed

Joffcom mentioned this pull request Aug 11, 2023

N8N will not send emails when user and pass is empty #6917

Closed

Joffcom added 2 commits August 14, 2023 12:32

Merge branch 'master' of github.com:n8n-io/n8n into smtp-no-auth

d85d7ad

Quick tweak

59b6830

Joffcom changed the title ~~Allow SMTP configuration without auth~~ feat: Add support for not requiring SMTP auth with user management Aug 14, 2023

Joffcom previously approved these changes Aug 14, 2023

View reviewed changes

netroy previously requested changes Aug 14, 2023

View reviewed changes

packages/cli/src/UserManagement/email/NodeMailer.ts Outdated Show resolved Hide resolved

Remove IDataObject

0f38e40

Joffcom dismissed their stale review via 0f38e40 August 15, 2023 08:37

Joffcom approved these changes Aug 15, 2023

View reviewed changes

Joffcom merged commit eead6d4 into n8n-io:master Aug 15, 2023
8 checks passed

Joffcom mentioned this pull request Aug 15, 2023

Update to mention smtp user and pass are optional n8n-io/n8n-docs#1555

Merged

github-actions bot mentioned this pull request Aug 16, 2023

🚀 Release 1.3.0 #6945

Merged

janober added the Released label Aug 16, 2023

netroy pushed a commit that referenced this pull request Aug 17, 2023

feat: Add support for not requiring SMTP auth with user management (#…

0db5af3

…3742)

github-actions bot mentioned this pull request Aug 17, 2023

🚀 Release 0.236.4 #6963

Closed

netroy pushed a commit that referenced this pull request Aug 17, 2023

feat: Add support for not requiring SMTP auth with user management (#…

fc97d18

…3742)

github-actions bot mentioned this pull request Aug 17, 2023

🚀 Release 0.237.0 #6965

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for not requiring SMTP auth with user management #3742

feat: Add support for not requiring SMTP auth with user management #3742

xavier-calland commented Jul 20, 2022

CLAassistant commented Jul 20, 2022 •

edited

Loading

nathanael-h commented Sep 1, 2022

github-actions bot commented Aug 14, 2023

codecov bot commented Aug 14, 2023 •

edited

Loading

Joffcom commented Aug 14, 2023

janober commented Aug 16, 2023

feat: Add support for not requiring SMTP auth with user management #3742

feat: Add support for not requiring SMTP auth with user management #3742

Conversation

xavier-calland commented Jul 20, 2022

CLAassistant commented Jul 20, 2022 • edited Loading

nathanael-h commented Sep 1, 2022

github-actions bot commented Aug 14, 2023

codecov bot commented Aug 14, 2023 • edited Loading

Codecov Report

Joffcom commented Aug 14, 2023

janober commented Aug 16, 2023

CLAassistant commented Jul 20, 2022 •

edited

Loading

codecov bot commented Aug 14, 2023 •

edited

Loading