-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix issue with key based credentials not being read correctly #6824
fix: Fix issue with key based credentials not being read correctly #6824
Conversation
…e-private-key-fields-in-creds-arent-password-fields
…e-private-key-fields-in-creds-arent-password-fields
…e-private-key-fields-in-creds-arent-password-fields
…e-private-key-fields-in-creds-arent-password-fields
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps these should be separate PRs, so that these fixes show up as individual entries in the diff and in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok looks good to me.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6824 +/- ##
==========================================
- Coverage 24.79% 24.79% -0.01%
==========================================
Files 3137 3137
Lines 191132 191145 +13
Branches 21062 21065 +3
==========================================
+ Hits 47400 47403 +3
- Misses 142766 142776 +10
Partials 966 966
☔ View full report in Codecov by Sentry. |
Passing run #1830 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
✅ All Cypress E2E specs passed |
Hi, we are really looking forward to this pull request being merged 😄 |
Hey @WebWeave, I would say maybe 45 minutes until it is merged 🙂 |
…e-private-key-fields-in-creds-arent-password-fields
* @param privateKey - The private key to format. | ||
* @returns The formatted private key. | ||
*/ | ||
export function formatPrivateKey(privateKey: string): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we should be moving code out of this file, and into this.helpers
. That way these utility functions are also available to 3rd-party nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@netroy that isn't a bad idea, Fancy making a tech debt ticket for it and we can move them all out on our next node team tech debt day
✅ All Cypress E2E specs passed |
✅ All Cypress E2E specs passed |
Got released with |
# [0.237.0](https://github.com/n8n-io/n8n/compare/n8n@0.236.3...n8n@0.237.0) (2023-08-17) ### Bug Fixes * **API:** Fix issue with workflow setting not supporting newer nanoids ([#6699](#6699)) ([2e64c9d](2e64c9d)) * **AwsS3 Node:** Fix issue if bucket name contains a '.' ([#6542](#6542)) ([219f897](219f897)) * **core:** Add missing primary key on the `execution_data` table on postgres ([#6797](#6797)) ([1c5f98d](1c5f98d)) * **core:** Fix `continueOnFail` for expression error in Set ([#6939](#6939)) ([2a3937f](2a3937f)) * **core:** Fix property existence checks on AugmentObject ([#6842](#6842)) ([3e4483a](3e4483a)) * **core:** Log crash causes to console when sentry is disabled ([#6890](#6890)) ([f19c9c1](f19c9c1)) * **core:** Restrict read/write file paths access ([#6582](#6582)) ([6e6b90e](6e6b90e)) * **core:** Serialize BigInts ([#6805](#6805)) ([17ce49b](17ce49b)) * **core:** Update frontend urls when using the `--tunnel` option ([#6898](#6898)) ([ec3c066](ec3c066)) * **core:** Update packages to address CVE-2023-2142 and CVE-2020-28469 ([#6844](#6844)) ([6dd0850](6dd0850)) * Correct typos in Taiga and ServiceNow nodes ([#6814](#6814)) ([b9f52ec](b9f52ec)) * **editor:** Fix code node’s content property to be reactive ([#6931](#6931)) ([f3b380d](f3b380d)) * **editor:** Prevent Code node linter from erroring on `null` parse ([#6934](#6934)) ([baada92](baada92)) * **Email Trigger (IMAP) Node:** UTF-8 attachments are not correctly named ([#6856](#6856)) ([f3f1c14](f3f1c14)) * **Email Trigger (IMAP) Node:** Fix connection issue with unexpected spaces in host ([#6886](#6886)) ([35c29ac](35c29ac)) * Fix issue with key based credentials not being read correctly ([#6824](#6824)) ([2459b0a](2459b0a)) * Fix issue with key formatting if null or undefined ([#6924](#6924)) ([59d33db](59d33db)) * Fix issue with key formatting introduced in 1.2.0 ([#6896](#6896)) ([8423153](8423153)) * **FTP Node:** List recursive ignore . and .. to prevent infinite loops ([#6707](#6707)) ([6a787dd](6a787dd)) * **GitLab Trigger Node:** Fix trigger activation 404 error ([#6711](#6711)) ([8c5145b](8c5145b)) * **Gmail Trigger Node:** Early returns in case of no data ([#6727](#6727)) ([df2f1d6](df2f1d6)) * **Google BigQuery Node:** Error description improvement ([#6715](#6715)) ([261d73e](261d73e)) * **GoToWebinar Node:** Fix issue with timezone incorrectly being required ([#6865](#6865)) ([2f61e34](2f61e34)) * **HTTP Request Node:** Improve error handling for TCP socket errors when `Continue On Fail` is enabled ([#6925](#6925)) ([e8e4c9e](e8e4c9e)) * **Lemlist Node:** Fix pagination issues with campaigns and activities ([#6734](#6734)) ([73eddc6](73eddc6)) * **Salesforce Node:** Fix Account update owner operation ([#6958](#6958)) ([e71ff76](e71ff76)) * **Telegram Trigger Node:** Add guard to 'include' call on null or undefined ([#6730](#6730)) ([c3c845c](c3c845c)) * **Todoist Node:** Fix issue with section id being ignored ([#6799](#6799)) ([e53f4a0](e53f4a0)) ### Features * Add support for not requiring SMTP auth with user management ([#3742](#3742)) ([fc97d18](fc97d18)) * **core:** Add support for ready hooks, and credentials overwrite endpoint in workers ([#6954](#6954)) ([e5986c5](e5986c5)) * **editor:** Add "Download" button if JSON data is to large ([#6850](#6850)) ([3d815cf](3d815cf)) * Enable parallel processing on multiple queue nodes ([#6295](#6295)) ([e45461a](e45461a)) Co-authored-by: netroy <netroy@users.noreply.github.com>
Github issue / Community forum post (link here to close automatically):