-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix issue with key based credentials not being read correctly #6824
Merged
Joffcom
merged 18 commits into
master
from
node-569-make-sure-private-key-fields-in-creds-arent-password-fields
Aug 9, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9bbc28e
Started
Joffcom 8145573
Merge branch 'master' of github.com:n8n-io/n8n into node-569-make-sur…
Joffcom c60acba
Fixed SFTP
Joffcom 9e5177d
Fixed Postgres tunnel with ssh key
Joffcom 5d9788d
Merge branch 'master' of github.com:n8n-io/n8n into node-569-make-sur…
Joffcom 1da64be
Merge branch 'master' of github.com:n8n-io/n8n into node-569-make-sur…
Joffcom 02d12a7
fix tunnel and SSH key with MySQL
Joffcom a4a746e
Fix ssl cert formats in MySQL node
Joffcom 5b33323
Updated formatPrivateKey to include PEM and Password protected keys
Joffcom d22a86b
Updated last couple of nodes to use new formatter
Joffcom 2be1190
Merge branch 'master' of github.com:n8n-io/n8n into node-569-make-sur…
Joffcom 752baa8
Fixed ftp node
Joffcom 7534aaf
Fixed SFTP credential
Joffcom 872ff3b
do not format keys that already include new lines (\n)
maspio e642927
Merge branch 'master' of github.com:n8n-io/n8n into node-569-make-sur…
Joffcom c654ffd
Update for Google Service Account
Joffcom 3cc175a
Fix for Google Service account
Joffcom d840d6b
Move import
Joffcom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we should be moving code out of this file, and into
this.helpers
. That way these utility functions are also available to 3rd-party nodes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@netroy that isn't a bad idea, Fancy making a tech debt ticket for it and we can move them all out on our next node team tech debt day