Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix multiOptions parameters resetting on initial load #6903

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

alexgrozav
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (718e613) 24.83% compared to head (d0d424e) 24.83%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6903      +/-   ##
==========================================
- Coverage   24.83%   24.83%   -0.01%     
==========================================
  Files        3144     3144              
  Lines      191261   191266       +5     
  Branches    21084    21083       -1     
==========================================
- Hits        47503    47502       -1     
- Misses     142781   142787       +6     
  Partials      977      977              
Files Changed Coverage Δ
packages/editor-ui/src/components/NodeSettings.vue 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OlegIvaniv
OlegIvaniv previously approved these changes Aug 10, 2023
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected. But it would be nice to add a small comment to why this is required

@cypress
Copy link

cypress bot commented Aug 10, 2023

Passing run #1846 ↗︎

0 221 0 0 Flakiness 0

Details:

🌳 ado-1006-cannot-enter-resource 🖥️ browsers:node18.12.0-chrome107 🤖 alexgroz...
Project: n8n Commit: d0d424e255
Status: Passed Duration: 06:43 💡
Started: Aug 10, 2023 8:15 AM Ended: Aug 10, 2023 8:22 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

1 similar comment
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 49867c2 into master Aug 10, 2023
18 checks passed
@alexgrozav alexgrozav deleted the ado-1006-cannot-enter-resource branch August 10, 2023 09:28
netroy pushed a commit that referenced this pull request Aug 14, 2023
…6903)

* fix: fix multiOptions parameters resetting on initial load

* chore: add comment
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
@janober
Copy link
Member

janober commented Aug 15, 2023

Got released with n8n@1.2.2

@github-actions github-actions bot mentioned this pull request Aug 16, 2023
netroy added a commit that referenced this pull request Aug 16, 2023
# [1.3.0](https://github.com/n8n-io/n8n/compare/n8n@1.2.0...n8n@1.3.0)
(2023-08-16)


### Bug Fixes

* **core:** Don't let bull override the default redis config
([#6897](#6897))
([cfeb322](cfeb322))
* **core:** Fix fetching of EE executions
([#6901](#6901))
([f3fce48](f3fce48))
* **core:** Update frontend urls when using the `--tunnel` option
([#6898](#6898))
([718e613](718e613))
* **editor:** Disable telemetry in dev mode and in E2E tests
([#6869](#6869))
([808a928](808a928))
* **editor:** Fix code node’s content property to be reactive
([#6931](#6931))
([3b75bc6](3b75bc6))
* **editor:** Fix event emit on credential sharing
([#6922](#6922))
([297c3c9](297c3c9))
* **editor:** Fix multiOptions parameters resetting on initial load
([#6903](#6903))
([49867c2](49867c2))
* **editor:** Update execution view layout
([#6882](#6882))
([0339732](0339732))
* **Email Trigger (IMAP) Node:** Fix connection issue with unexpected
spaces in host ([#6886](#6886))
([f3248e4](f3248e4))
* Fix issue with key formatting if null or undefined
([#6924](#6924))
([4e4a3cf](4e4a3cf))
* Fix issue with key formatting introduced in 1.2.0
([#6896](#6896))
([0e075c9](0e075c9))
* Fix lag when node parameters are updated
([#6941](#6941))
([3eb65e0](3eb65e0))
* **HTTP Request Node:** Improve error handling for TCP socket errors
when `Continue On Fail` is enabled
([#6925](#6925))
([96ff1f8](96ff1f8))
* Prevent workflow breaking when credential type is unknown
([#6923](#6923))
([e83b93f](e83b93f))
* **Respond to Webhook Node:** Return headers in response
([#6921](#6921))
([a82107f](a82107f))


### Features

* **core:** Add support for not requiring SMTP auth with user management
([#3742](#3742))
([eead6d4](eead6d4))
* **core:** Descriptive message for common nodeJS errors
([#6841](#6841))
([3adb0b6](3adb0b6))
* **editor:** Ask AI in Code node
([#6672](#6672))
([fde6ad1](fde6ad1))
* Enable parallel processing on multiple queue nodes
([#6295](#6295))
([44afcff](44afcff))

Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants