Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Switch Node): Allow sortable Switch rules #7555

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix(Switch Node): Allow sortable Switch rules #7555

merged 1 commit into from
Oct 31, 2023

Conversation

OlegIvaniv
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@OlegIvaniv
fix(Switch node): Allow sortable Switch rules
d521a9c 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@Joffcom Joffcom changed the title fix(Switch node): Allow sortable Switch rules fix(Switch Node): Allow sortable Switch rules Oct 30, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (655efea) 33.58% compared to head (d521a9c) 33.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7555   +/-   ##
=======================================
  Coverage   33.58%   33.58%           
=======================================
  Files        3404     3404           
  Lines      207962   207962           
  Branches    22498    22498           
=======================================
+ Hits        69848    69849    +1     
+ Misses     136963   136962    -1     
  Partials     1151     1151
Files Coverage Δ
...ckages/nodes-base/nodes/Switch/V2/SwitchV2.node.ts 38.88% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Oct 30, 2023 •
edited
Loading

1 flaky test on run #2634 ↗︎

0 262 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: d521a9cd94
Status: Passed Duration: 10:32 💡
Started: Oct 31, 2023 7:39 AM Ended: Oct 31, 2023 7:50 AM
Flakiness  cypress/e2e/29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > can import template Output Screenshots Video

Review all test suite changes for PR #7555 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 7a56e58 into master Oct 31, 2023
56 of 58 checks passed
@OlegIvaniv OlegIvaniv deleted the allow-switch-rules-sort branch October 31, 2023 08:13
MiloradFilipovic added a commit that referenced this pull request Oct 31, 2023
@MiloradFilipovic
Merge branch 'master' into ADO-1294-collab-avatars-component
26067b2 
* master:
  fix(editor): Keep NodeView component alive for `TEMPLATE_IMPORT` and `WORKFLOW_ONBOARDING` routes (no-changelog) (#7557)
  fix(Switch Node): Allow sortable Switch rules (#7555)
  feat(core): Add optional Error-Output (#7460)
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
krynble added a commit that referenced this pull request Nov 2, 2023
@github-actions @krynble
🚀 Release 1.15.0 (#7580)
73e9a21 
#
[1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0)
(2023-11-02)


### Bug Fixes

* **core:** Ensure execution deletion in worker lifecycle hook
([#7481](#7481))
([742c8a8](742c8a8))
* **core:** Fix data encryption on credentials import
([#7560](#7560))
([b350568](b350568))
* **core:** Fix issue that prevents owner logging in when using ldap
([#7408](#7408))
([479f902](479f902))
* **core:** Handle missing resultData in runData
([#7523](#7523))
([1055bd3](1055bd3))
* **core:** Permission check for subworkflow properly checking for
workflow settings ([#7576](#7576))
([437c95e](437c95e))
* **core:** Prevent executions from becoming forever running
([#7569](#7569))
([9bdb85c](9bdb85c))
* **core:** Upgrade crypto-js to address CVE-2023-46233
([#7519](#7519))
([65e5593](65e5593))
* **editor:** Do not truncate form inputs
([#7528](#7528))
([ae616f1](ae616f1))
* **editor:** Fix NDV close after using input select
([#7544](#7544))
([3b5e181](3b5e181))
* **editor:** Fix NDV unexpected re-render
([#7532](#7532))
([2853fcf](2853fcf))
* **editor:** Fix route component caching, incorrect use of array reduce
method and enable WF history feature
([#7434](#7434))
([12a89e6](12a89e6))
* **editor:** Fixes the issue that Switch Node can not be created
([#7516](#7516))
([df89685](df89685))
* **editor:** Handle `localStorage` being blocked/unavailable
([#7348](#7348))
([c05bc67](c05bc67))
* **Jira Software Node:** Handle missing issue types in issue types
loader ([#7534](#7534))
([9762705](9762705))
* **Switch Node:** Allow sortable Switch rules
([#7555](#7555))
([7a56e58](7a56e58))


### Features

* **core:** Add optional Error-Output
([#7460](#7460))
([655efea](655efea))
* **core:** Make queue mode settings configurable
([#7526](#7526))
([3d95b24](3d95b24))
* **core:** Set up leader selection for multiple main instances
([#7527](#7527))
([442c73e](442c73e))
* **editor:** Implement the `UserStack` design system component
([#7559](#7559))
([ce14f62](ce14f62))
* **HTTP Request Node:** Add pagination support
([#5993](#5993))
([cc2bd2e](cc2bd2e))
* **HTTP Request Node:** Update icon and default color
([#7572](#7572))
([ff279ab](ff279ab))
* **n8n Form Trigger Node:** Add text area and password input types
([#7474](#7474))
([b72040a](b72040a))
* **editor:** Dark mode is here! You can change it under personal
settings.([#6980](#6980))
([0746783](0746783))

---------

Co-authored-by: krynble <krynble@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
krynble added a commit that referenced this pull request Nov 2, 2023
@github-actions @krynble
🚀 Release 1.15.1 (#7592)
fbce8f5 
##
[1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1)
(2023-11-02)


### Bug Fixes

* **core:** Ensure execution deletion in worker lifecycle hook
([#7481](#7481))
([742c8a8](742c8a8))
* **core:** Fix data encryption on credentials import
([#7560](#7560))
([b350568](b350568))
* **core:** Fix issue that prevents owner logging in when using ldap
([#7408](#7408))
([479f902](479f902))
* **core:** Handle missing resultData in runData
([#7523](#7523))
([1055bd3](1055bd3))
* **core:** Permission check for subworkflow properly checking for
workflow settings ([#7576](#7576))
([437c95e](437c95e))
* **core:** Prevent executions from becoming forever running
([#7569](#7569))
([9bdb85c](9bdb85c))
* **core:** Upgrade crypto-js to address CVE-2023-46233
([#7519](#7519))
([65e5593](65e5593))
* **editor:** Do not truncate form inputs
([#7528](#7528))
([ae616f1](ae616f1))
* **editor:** Fix NDV close after using input select
([#7544](#7544))
([3b5e181](3b5e181))
* **editor:** Fix NDV unexpected re-render
([#7532](#7532))
([2853fcf](2853fcf))
* **editor:** Fix route component caching, incorrect use of array reduce
method and enable WF history feature
([#7434](#7434))
([12a89e6](12a89e6))
* **editor:** Fixes the issue that Switch Node can not be created
([#7516](#7516))
([df89685](df89685))
* **editor:** Handle `localStorage` being blocked/unavailable
([#7348](#7348))
([c05bc67](c05bc67))
* Fix dark mode small issues
([#7573](#7573))
([1d81afc](1d81afc))
* **Jira Software Node:** Handle missing issue types in issue types
loader ([#7534](#7534))
([9762705](9762705))
* **Switch Node:** Allow sortable Switch rules
([#7555](#7555))
([7a56e58](7a56e58))


### Features

* **core:** Add optional Error-Output
([#7460](#7460))
([655efea](655efea))
* **core:** Make queue mode settings configurable
([#7526](#7526))
([3d95b24](3d95b24))
* **core:** Set up leader selection for multiple main instances
([#7527](#7527))
([442c73e](442c73e))
* **editor:** Implement the `UserStack` design system component
([#7559](#7559))
([ce14f62](ce14f62))
* **HTTP Request Node:** Add pagination support
([#5993](#5993))
([cc2bd2e](cc2bd2e))
* **HTTP Request Node:** Update icon and default color
([#7572](#7572))
([ff279ab](ff279ab))
* **n8n Form Trigger Node:** Add text area and password input types
([#7474](#7474))
([b72040a](b72040a))
* **editor:** Dark mode is here! You can change it under personal
settings.([#6980](#6980))
([0746783](0746783))

---------

Co-authored-by: krynble <krynble@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
@janober
Copy link
Member

janober commented Nov 2, 2023

Got released with n8n@1.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegIvaniv @janober @Joffcom