fix(core): Permission check for subworkflow properly checking for workflow settings #7576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k for workflow settings only
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7576 +/- ##
=======================================
Coverage 33.74% 33.74%
=======================================
Files 3408 3408
Lines 208594 208583 -11
Branches 22565 22559 -6
=======================================
- Hits 70396 70394 -2
+ Misses 137051 137041 -10
- Partials 1147 1148 +1
☔ View full report in Codecov by Sentry. |
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
ivov
previously approved these changes
Nov 1, 2023
Passing run #2672 ↗︎
Details:
Review all test suite changes for PR #7576 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
ivov
approved these changes
Nov 1, 2023
|
✅ All Cypress E2E specs passed |
1 similar comment
|
✅ All Cypress E2E specs passed |
krynble
deleted the
help-373-parent-workflow-fails-to-execute-when-sub-workflow-is-shared
branch
Merged
krynble
added a commit
that referenced
this pull request
Nov 2, 2023
# [1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0) (2023-11-02) ### Bug Fixes * **core:** Ensure execution deletion in worker lifecycle hook ([#7481](#7481)) ([742c8a8](742c8a8)) * **core:** Fix data encryption on credentials import ([#7560](#7560)) ([b350568](b350568)) * **core:** Fix issue that prevents owner logging in when using ldap ([#7408](#7408)) ([479f902](479f902)) * **core:** Handle missing resultData in runData ([#7523](#7523)) ([1055bd3](1055bd3)) * **core:** Permission check for subworkflow properly checking for workflow settings ([#7576](#7576)) ([437c95e](437c95e)) * **core:** Prevent executions from becoming forever running ([#7569](#7569)) ([9bdb85c](9bdb85c)) * **core:** Upgrade crypto-js to address CVE-2023-46233 ([#7519](#7519)) ([65e5593](65e5593)) * **editor:** Do not truncate form inputs ([#7528](#7528)) ([ae616f1](ae616f1)) * **editor:** Fix NDV close after using input select ([#7544](#7544)) ([3b5e181](3b5e181)) * **editor:** Fix NDV unexpected re-render ([#7532](#7532)) ([2853fcf](2853fcf)) * **editor:** Fix route component caching, incorrect use of array reduce method and enable WF history feature ([#7434](#7434)) ([12a89e6](12a89e6)) * **editor:** Fixes the issue that Switch Node can not be created ([#7516](#7516)) ([df89685](df89685)) * **editor:** Handle `localStorage` being blocked/unavailable ([#7348](#7348)) ([c05bc67](c05bc67)) * **Jira Software Node:** Handle missing issue types in issue types loader ([#7534](#7534)) ([9762705](9762705)) * **Switch Node:** Allow sortable Switch rules ([#7555](#7555)) ([7a56e58](7a56e58)) ### Features * **core:** Add optional Error-Output ([#7460](#7460)) ([655efea](655efea)) * **core:** Make queue mode settings configurable ([#7526](#7526)) ([3d95b24](3d95b24)) * **core:** Set up leader selection for multiple main instances ([#7527](#7527)) ([442c73e](442c73e)) * **editor:** Implement the `UserStack` design system component ([#7559](#7559)) ([ce14f62](ce14f62)) * **HTTP Request Node:** Add pagination support ([#5993](#5993)) ([cc2bd2e](cc2bd2e)) * **HTTP Request Node:** Update icon and default color ([#7572](#7572)) ([ff279ab](ff279ab)) * **n8n Form Trigger Node:** Add text area and password input types ([#7474](#7474)) ([b72040a](b72040a)) * **editor:** Dark mode is here! You can change it under personal settings.([#6980](#6980)) ([0746783](0746783)) --------- Co-authored-by: krynble <krynble@users.noreply.github.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>
Merged
krynble
added a commit
that referenced
this pull request
Nov 2, 2023
## [1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1) (2023-11-02) ### Bug Fixes * **core:** Ensure execution deletion in worker lifecycle hook ([#7481](#7481)) ([742c8a8](742c8a8)) * **core:** Fix data encryption on credentials import ([#7560](#7560)) ([b350568](b350568)) * **core:** Fix issue that prevents owner logging in when using ldap ([#7408](#7408)) ([479f902](479f902)) * **core:** Handle missing resultData in runData ([#7523](#7523)) ([1055bd3](1055bd3)) * **core:** Permission check for subworkflow properly checking for workflow settings ([#7576](#7576)) ([437c95e](437c95e)) * **core:** Prevent executions from becoming forever running ([#7569](#7569)) ([9bdb85c](9bdb85c)) * **core:** Upgrade crypto-js to address CVE-2023-46233 ([#7519](#7519)) ([65e5593](65e5593)) * **editor:** Do not truncate form inputs ([#7528](#7528)) ([ae616f1](ae616f1)) * **editor:** Fix NDV close after using input select ([#7544](#7544)) ([3b5e181](3b5e181)) * **editor:** Fix NDV unexpected re-render ([#7532](#7532)) ([2853fcf](2853fcf)) * **editor:** Fix route component caching, incorrect use of array reduce method and enable WF history feature ([#7434](#7434)) ([12a89e6](12a89e6)) * **editor:** Fixes the issue that Switch Node can not be created ([#7516](#7516)) ([df89685](df89685)) * **editor:** Handle `localStorage` being blocked/unavailable ([#7348](#7348)) ([c05bc67](c05bc67)) * Fix dark mode small issues ([#7573](#7573)) ([1d81afc](1d81afc)) * **Jira Software Node:** Handle missing issue types in issue types loader ([#7534](#7534)) ([9762705](9762705)) * **Switch Node:** Allow sortable Switch rules ([#7555](#7555)) ([7a56e58](7a56e58)) ### Features * **core:** Add optional Error-Output ([#7460](#7460)) ([655efea](655efea)) * **core:** Make queue mode settings configurable ([#7526](#7526)) ([3d95b24](3d95b24)) * **core:** Set up leader selection for multiple main instances ([#7527](#7527)) ([442c73e](442c73e)) * **editor:** Implement the `UserStack` design system component ([#7559](#7559)) ([ce14f62](ce14f62)) * **HTTP Request Node:** Add pagination support ([#5993](#5993)) ([cc2bd2e](cc2bd2e)) * **HTTP Request Node:** Update icon and default color ([#7572](#7572)) ([ff279ab](ff279ab)) * **n8n Form Trigger Node:** Add text area and password input types ([#7474](#7474)) ([b72040a](b72040a)) * **editor:** Dark mode is here! You can change it under personal settings.([#6980](#6980)) ([0746783](0746783)) --------- Co-authored-by: krynble <krynble@users.noreply.github.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sharingrelated code is legacy that was not removed. Subworkflow execution should check workflow settings alone, and this is now reflected in the code.Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/bug-when-using-the-execute-workflow-node-when-workflow-is-shared/32207