Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Venafi TLS Protect Cloud Node): Remove parameter Application Server Type #8325

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jan 12, 2024

Summary

Parameter was removed from the API.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)

@RicardoE105 RicardoE105 changed the title Remove unused parameter fix(Venafi TLS Protect Cloud): Remove parameter Application Server Type Jan 12, 2024
@RicardoE105 RicardoE105 changed the title fix(Venafi TLS Protect Cloud): Remove parameter Application Server Type fix(Venafi TLS Protect Cloud Node): Remove parameter Application Server Type Jan 12, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 12, 2024
@Joffcom
Copy link
Member

Joffcom commented Jan 15, 2024

Is the node currently broken if we send this and if this is set and we remove it does it lead to the workflows breaking?

Copy link

cypress bot commented Jan 15, 2024

1 flaky test on run #3761 ↗︎

0 331 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project: n8n Commit: 21beb1c2f3
Status: Passed Duration: 03:18 💡
Started: Jan 15, 2024 2:16 PM Ended: Jan 15, 2024 2:19 PM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > maps paired input and output items based on selected run Test Replay Screenshots Video

Review all test suite changes for PR #8325 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit e3cedf7 into master Jan 15, 2024
28 of 31 checks passed
@RicardoE105 RicardoE105 deleted the nodes/fix-venafi-node branch January 15, 2024 14:26
netroy pushed a commit that referenced this pull request Jan 16, 2024
…ver Type` (#8325)

## Summary
Parameter was removed from the API. 

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
@janober
Copy link
Member

janober commented Jan 16, 2024

Got released with n8n@1.24.1

@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants