Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Venafi TLS Protect Cloud Node): Remove parameter Application Server Type #8325

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(Venafi TLS Protect Cloud Node): Remove parameter Application Server Type #8325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions packages/nodes-base/nodes/Venafi/ProtectCloud/CertificateRequestDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,24 +86,6 @@ export const certificateRequestFields: INodeProperties[] = [
},
default: false,
},
{
displayName: 'Application Server Type Name or ID',
name: 'applicationServerTypeId',
type: 'options',
description:
'Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/code-examples/expressions/">expression</a>',
typeOptions: {
loadOptionsMethod: 'getApplicationServerTypes',
},
displayOptions: {
show: {
operation: ['create'],
resource: ['certificateRequest'],
generateCsr: [true],
},
},
default: '',
},
{
displayName: 'Common Name',
name: 'commonName',
Expand Down
22 changes: 0 additions & 22 deletions packages/nodes-base/nodes/Venafi/ProtectCloud/VenafiTlsProtectCloud.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,23 +88,6 @@ export class VenafiTlsProtectCloud implements INodeType {
}
return returnData;
},
async getApplicationServerTypes(
this: ILoadOptionsFunctions,
): Promise<INodePropertyOptions[]> {
const returnData: INodePropertyOptions[] = [];
const { applicationServerTypes } = await venafiApiRequest.call(
this,
'GET',
'/outagedetection/v1/applicationservertypes',
);
for (const applicationServerType of applicationServerTypes) {
returnData.push({
name: applicationServerType.platformName,
value: applicationServerType.id,
});
}
return returnData;
},
async getCertificateIssuingTemplates(
this: ILoadOptionsFunctions,
): Promise<INodePropertyOptions[]> {
Expand Down Expand Up @@ -157,10 +140,6 @@ export class VenafiTlsProtectCloud implements INodeType {
};

if (generateCsr) {
const applicationServerTypeId = this.getNodeParameter(
'applicationServerTypeId',
i,
) as string;
const commonName = this.getNodeParameter('commonName', i) as string;
const additionalFields = this.getNodeParameter('additionalFields', i);

Expand All @@ -169,7 +148,6 @@ export class VenafiTlsProtectCloud implements INodeType {
const subjectAltNamesByType: ISubjectAltNamesByType = {};

body.isVaaSGenerated = true;
body.applicationServerTypeId = applicationServerTypeId;

csrAttributes.commonName = commonName;

Expand Down
Loading