feat(core): Email recipients on resource shared #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
approved these changes
Jan 23, 2024
Comment on lines
+849
to
+860
| workflowShared: { | ||
| doc: 'Overrides default HTML template for notifying that a workflow was shared (use full path)', | ||
| format: String, | ||
| default: '', | ||
| env: 'N8N_UM_EMAIL_TEMPLATES_WORKFLOW_SHARED', | ||
| }, | ||
| credentialsShared: { | ||
| doc: 'Overrides default HTML template for notifying that credentials were shared (use full path)', | ||
| format: String, | ||
| default: '', | ||
| env: 'N8N_UM_EMAIL_TEMPLATES_CREDENTIALS_SHARED', | ||
| }, |
There was a problem hiding this comment.
I've always wondered why we do it this way. can we not ask users to overwrite the files by using docker volumes, or even extending the official images with custom templates.
I believe that the burden of customization related code should lie on the party making those customizations.
There was a problem hiding this comment.
@maspio Do you happen to know if embed customers usually need to customize email templates?
1 flaky test on run #3874 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8408 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
deleted the
pay-1149-add-confirmation-email-when-user-shares-a-resource-with
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-1149