fix(core): Prevent calling internal hook email event if emailing is disabled #8462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
requested changes
Jan 26, 2024
n8n-assistant
bot
added
core
netroy
requested changes
Jan 26, 2024
…ernal-hook-event-if-email-not-sent
netroy
requested changes
Jan 29, 2024
| private readonly urlService: UrlService, | ||
| private readonly internalHooks: InternalHooks, |
There was a problem hiding this comment.
we can't do this yet. there is still an annoying circular dependency that'll prevent the app from actually starting up.
Comment on lines
52
to
53
| Container.get(UserService).setMailer(mailer); | ||
| Container.get(InvitationController).setExternalHooks(externalHooks); |
There was a problem hiding this comment.
I'd prefer not start using this format. All dependencies should be injected, and never modified after that.
To fix this test, we need to move all calls to mockInstance to be before setupTestServer, and that should do the trick.
There was a problem hiding this comment.
Thank you, I had a feeling this was not the way but could not find the answer in a short time.
netroy
approved these changes
Jan 29, 2024
3 flaky tests on run #3947 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
28-debug.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Debug > should be able to debug executions |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8462 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
deleted the
prevent-calling-internal-hook-event-if-email-not-sent
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 30, 2024
…error-states * master: fix(editor): Send template id as a number in telemetry events (#8484) refactor(core): Replace promisify-d node calls with native promises (no-changelog) (#8464) fix(core): Fix stopping and retrying failed executions (#8480) feat: Add model parameter to OpenAI embeddings (#8481) fix(editor): Disable expression editor modal opening on readonly field (#8457) fix(core): Prevent calling internal hook email event if emailing is disabled (#8462)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we do not call telemetry event
Instance sent transactional email to userIf emailing is disabled when resource is shared.Follow-up to: #8408