Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Prevent calling internal hook email event if emailing is disabled #8462

Merged
merged 12 commits into from
Jan 29, 2024
Merged

fix(core): Prevent calling internal hook email event if emailing is disabled #8462

merged 12 commits into from
Jan 29, 2024

Commits on Jan 26, 2024

  1. fix(core): Prevent calling internal hook email event if emailing is d… 

    …isabled
    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    85b3c26 View commit details
    Browse the repository at this point in the history

  2. Encapsulate in mailer

    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f66fda4 View commit details
    Browse the repository at this point in the history

  3. Remove logging

    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    040f3c3 View commit details
    Browse the repository at this point in the history

  4. No nesting in arg object

    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8f8a11e View commit details
    Browse the repository at this point in the history

  5. Check for this.mailer to simplify

    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e66c63a View commit details
    Browse the repository at this point in the history

  6. Move try-catch inside mailer methods

    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4f96902 View commit details
    Browse the repository at this point in the history

  7. Pass entire workflow

    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f71b2d9 View commit details
    Browse the repository at this point in the history

  8. Silly oversight

    @ivov
    ivov committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0a41938 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Fix tests

    @ivov
    ivov committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    4e7745e View commit details
    Browse the repository at this point in the history

  2. fix the tests without the dependency hack

    @netroy
    netroy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a043c6a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into prevent-calling-int… 

    …ernal-hook-event-if-email-not-sent
    @netroy
    netroy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    107f382 View commit details
    Browse the repository at this point in the history

  4. workaround another circular dependency

    @netroy
    netroy committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6db306e View commit details
    Browse the repository at this point in the history