fix(RabbitMQ Node): Fix issue with arguments not being sent #9397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Joffcom
changed the title
michael-radency
requested changes
May 31, 2024
…q-arguments-are-not-actually-sent
|
@michael-radency fancy giving it another bash, Have updated and given it a quick test with and without options being set and all is good. |
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #6006 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should auto load more items if there is space and auto scroll |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9397 ↗︎
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Arguments set were ignored, this adds them and assumes they will be in the amqplib
Options.Publishformat, Tested with RMQ 3.12.11 usingcontentTypeandpersistentas test values.RMQ Management UI
Related tickets and issues
#2806
https://linear.app/n8n/issue/NODE-1031
https://community.n8n.io/t/rabbitmq-priority-queues/46596