-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RabbitMQ Node): Fix issue with arguments not being sent #9397
Merged
Joffcom
merged 5 commits into
master
from
node-1031-rabbitmq-arguments-are-not-actually-sent
Jul 19, 2024
Merged
fix(RabbitMQ Node): Fix issue with arguments not being sent #9397
Joffcom
merged 5 commits into
master
from
node-1031-rabbitmq-arguments-are-not-actually-sent
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
May 14, 2024
Joffcom
changed the title
fix(RabbitMQ Node): Fix issue with arguments not being to queues
fix(RabbitMQ Node): Fix issue with arguments not being sent
May 29, 2024
michael-radency
requested changes
May 31, 2024
…q-arguments-are-not-actually-sent
@michael-radency fancy giving it another bash, Have updated and given it a quick test with and without options being set and all is good. |
michael-radency
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ All Cypress E2E specs passed |
2 flaky tests on run #6006 ↗︎
Details:
5-ndv.cy.ts • 1 flaky test
20-workflow-executions.cy.ts • 1 flaky test
Review all test suite changes for PR #9397 ↗︎ |
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Arguments set were ignored, this adds them and assumes they will be in the amqplib
Options.Publish
format, Tested with RMQ 3.12.11 usingcontentType
andpersistent
as test values.RMQ Management UI
Related tickets and issues
#2806
https://linear.app/n8n/issue/NODE-1031
https://community.n8n.io/t/rabbitmq-priority-queues/46596