-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Node Creator AI nodes improvements #9484
feat(editor): Node Creator AI nodes improvements #9484
Conversation
… to use it Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
4 flaky tests on run #5185 ↗︎
Details:
5-ndv.cy.ts • 2 flaky tests
20-workflow-executions.cy.ts • 1 flaky test
24-ndv-paired-item.cy.ts • 1 flaky test
Review all test suite changes for PR #9484 ↗︎ |
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
b0a9e06
to
0039745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍 left some small code comments
packages/design-system/src/components/N8nNodeCreatorNode/NodeCreatorNode.vue
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/Node/NodeCreator/Renderers/ItemsRenderer.vue
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/Node/NodeCreator/Renderers/ItemsRenderer.vue
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/Node/NodeCreator/composables/useViewStacks.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@elsmr Thanks for the review! I've addressed your feedback; could you have another look, please? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
* master: fix(editor): Fix ts errors across the board (no-changelog) (#9561) refactor(core): Extract all Auth-related User columns into a separate entity (#9557) refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527) fix(editor): Render checkboxes in markdown (#9549) test(core): Rename and combine all credential api tests (no-changelog) (#9550) 🚀 Release 1.44.0 (#9553) feat(editor): Node Creator AI nodes improvements (#9484) fix(editor): Show workflow data in header when execution page is hard reloaded (#9529) refactor(core): Stop reporting to Sentry `NodeApiError` with 5xx status codes (no-changelog) (#9552) feat: HighLevel oauth2 api credentials (#9542) fix(editor): Fix empty node name handling (#9548) ci: Fix vulnerable dev dependencies (no-changelog) (#9545) fix: Don't throw errors for NaN in number operators in the filter component (#9506) fix(core): Try setting postgres search_path on the database (#9530) fix(editor): Redirect to workflows list after deleting a workflow (#9546) # Conflicts: # packages/editor-ui/src/views/NodeView.vue # pnpm-lock.yaml
Got released with |
Summary
This PR implements several AI-nodes-related UX/UI improvements to the Node Creator panel.
CleanShot.2024-05-22.at.11.25.37.mp4
Related tickets and issues
Review / Merge checklist
(no-changelog)
otherwise. (conventions)