feat(editor): Tweak node creator search logic for AI sub-nodes #10025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
OlegIvaniv
changed the title
n8n-assistant
bot
added
n8n team
2 flaky tests on run #5898 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #10025 ↗︎
elsmr
approved these changes
Jul 12, 2024
|
|
||
| if ( | ||
| // Filter-out AI sub-nodes if canvas has no AI nodes and the root view is not AI | ||
| !(isAiRootView(stack) || canvasHasAINodes) || |
There was a problem hiding this comment.
nit: Could extract isAiRootView(stack) || canvasHasAINodes into a new computed (also used below in groupIfAiRootNodes
|
|
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-195-node-subcategory-display-and-insertion-tweaks
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the following tweaks for node creator:
node_connection_droporplus_endpointsourcelastSelectedNodeif chat trigger is auto-addedRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)