-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Remove Segment #9878
Conversation
@@ -34,474 +10,4 @@ export const n8nCloudHooks: PartialDeep<ExternalHooks> = { | |||
}, | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping this here since we agreed to keep external hooks and deprecate in v2
https://n8nio.slack.com/archives/C03594NKD7W/p1719481324464849
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a @deprecated
notice and mention that these are being deprecated in v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 One comment about deprecation notice
@@ -34,474 +10,4 @@ export const n8nCloudHooks: PartialDeep<ExternalHooks> = { | |||
}, | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a @deprecated
notice and mention that these are being deprecated in v2
4 flaky tests on run #5705 ↗︎
Details:
5-ndv.cy.ts • 2 flaky tests
10-undo-redo.cy.ts • 2 flaky tests
Review all test suite changes for PR #9878 ↗︎ |
✅ All Cypress E2E specs passed |
@tomi the deprecation is not decided yet. Would handle that separately once we have agreed with Product on this. |
Got released with |
Summary
Remove Segment. Only enabled when Segment library is injected on Cloud
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)