Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Remove Segment #9878

Merged
merged 9 commits into from
Jun 28, 2024
Merged

feat(editor): Remove Segment #9878

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7b98f7a
refactor: Remove Segment tracking from Cloud
mutdmour Jun 27, 2024
bcccf7b
fix: clean up external hooks
mutdmour Jun 27, 2024
a6e201b
Revert "fix: clean up external hooks"
mutdmour Jun 27, 2024
6f8c110
fix: remove segment
mutdmour Jun 27, 2024
968318a
refactor: remove segment hook
mutdmour Jun 27, 2024
3a0c97a
refactor: remove segment hook
mutdmour Jun 27, 2024
45df1cf
refactor: remove segment hook
mutdmour Jun 27, 2024
8337061
Revert "refactor: remove segment hook"
mutdmour Jun 27, 2024
5515fac
refactor: fix up segment types
mutdmour Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/editor-ui/src/components/ParameterInputFull.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ import ParameterOptions from '@/components/ParameterOptions.vue';
import { useI18n } from '@/composables/useI18n';
import { useToast } from '@/composables/useToast';
import { useNDVStore } from '@/stores/ndv.store';
import { useSegment } from '@/stores/segment.store';
import { getMappedResult } from '@/utils/mappingUtils';
import { hasExpressionMapping, hasOnlyListMode, isValueExpression } from '@/utils/nodeTypesUtils';
import { isResourceLocatorValue } from '@/utils/typeGuards';
Expand Down Expand Up @@ -272,9 +271,6 @@ function onDrop(newParamValue: string) {
hasExpressionMapping(prevValue),
success: true,
});

const segment = useSegment();
segment.track(segment.EVENTS.MAPPED_DATA);
}
forceShowExpression.value = false;
}, 200);
Expand Down
2 changes: 0 additions & 2 deletions packages/editor-ui/src/composables/useCanvasOperations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ import { useI18n } from '@/composables/useI18n';
import { useToast } from '@/composables/useToast';
import * as NodeViewUtils from '@/utils/nodeViewUtils';
import { v4 as uuid } from 'uuid';
import { useSegment } from '@/stores/segment.store';
import type { Ref } from 'vue';
import { computed } from 'vue';
import { useCredentialsStore } from '@/stores/credentials.store';
Expand Down Expand Up @@ -650,7 +649,6 @@ export function useCanvasOperations({
});
} else {
void externalHooks.run('nodeView.addNodeButton', { nodeTypeName: node.type });
useSegment().trackAddedTrigger(node.type);
const trackProperties: ITelemetryTrackProperties = {
node_type: node.type,
node_version: newNodeData.typeVersion,
Expand Down
4 changes: 0 additions & 4 deletions packages/editor-ui/src/composables/usePushConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export function usePushConnection({ router }: { router: ReturnType<typeof useRou
const orchestrationManagerStore = useOrchestrationStore();
const pushStore = usePushConnectionStore();
const settingsStore = useSettingsStore();
const segmentStore = useSegment();
const uiStore = useUIStore();
const workflowsStore = useWorkflowsStore();

Expand Down Expand Up @@ -521,9 +520,6 @@ export function usePushConnection({ router }: { router: ReturnType<typeof useRou
runDataExecutedStartData: runDataExecuted.data.startData,
resultDataError: runDataExecuted.data.resultData.error,
});
if (!runDataExecuted.data.resultData.error) {
segmentStore.trackSuccessfulWorkflowExecution(runDataExecuted);
}
} else if (receivedData.type === 'executionStarted') {
const pushData = receivedData.data;

Expand Down
Loading
Loading