Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove unused Sentry report from WaitTracker (no-changelog) #10008

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 11, 2024

Added at #8356, fixed at n8n-io/typeorm#7, no Sentry reports in 90 days.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 11, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 11, 2024

4 flaky tests on run #5872 ↗︎

0 399 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 5d085d0ea5
Status: Passed Duration: 05:12 💡
Started: Jul 11, 2024 10:35 AM Ended: Jul 11, 2024 10:40 AM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #10008 ↗︎

@ivov ivov merged commit e3c138f into master Jul 11, 2024
27 checks passed
@ivov ivov deleted the remove-unused-sentry-report-from-waittracker branch July 11, 2024 10:44
@janober
Copy link
Member

janober commented Jul 17, 2024

Got released with n8n@1.51.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants