fix(core): Fix SSH Tunnels when using private key #10148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
added
the
release/backport
Joffcom
approved these changes
Jul 23, 2024
n8n-assistant
bot
added
n8n team
Passing run #6098 ↗︎
Details:
Review all test suite changes for PR #10148 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
elsmr
pushed a commit
that referenced
this pull request
Jul 23, 2024
Merged
elsmr
pushed a commit
that referenced
this pull request
Jul 23, 2024
Merged
|
Got released with |
Merged
cstuncsik
pushed a commit
that referenced
this pull request
Jul 31, 2024
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in #9906 I accidentally changed the property names for private-key for SSH tunnels.
I had originally changed the name during testing, but had reverted to the original names. Unfortunately (since our schemas aren't typesafe), I missed one spot.
This means that any new Postgres or MySQL credential created on version 1.50 or 1.51, with SSH tunneling using private-key are not working right now.
Once this fix is released, those non-working credentials would need to be edited, and the private-key/passphrase would need to be re-entered.
Related Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/node-mysql-with-ssh-tunnel-configuration/50412
https://community.n8n.io/t/unable-to-connect-postgres-db-with-n8n/39615
Review / Merge checklist
release/backport