Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Google Sheets Node): Add column names row if sheet is empty #10200

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(Google Sheets Node): Add column names row if sheet is empty #10200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1635e16
fix
michael-radency Jul 26, 2024
751d54b
Update packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append…
michael-radency Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,10 @@ export async function execute(
//if no trailing empty row exists in the sheet update operation will fail
await sheet.appendEmptyRowsOrColumns(sheetId, 1, 0);

const lastRow = (sheetData ?? []).length + 1;
// if sheetData is undefined it means that the sheet was empty
// we did add row with column names in the first row (autoMapInputData)
// to account for that length has to be 1 and we append data in the next row
const lastRow = (sheetData ?? [{}]).length + 1;

await sheet.appendSheetData({
inputData,
Expand Down
Loading