Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Postgres Chat Memory, Redis Chat Memory, Xata): Add support for context window length #10203

Merged
merged 6 commits into from
Aug 6, 2024
Merged

feat(Postgres Chat Memory, Redis Chat Memory, Xata): Add support for context window length #10203

merged 6 commits into from
Aug 6, 2024

Conversation

jeanpaul
Copy link
Contributor

@jeanpaul jeanpaul commented Jul 26, 2024 •
edited
Loading

Summary

Add the context window length option to the Postgres, Redis and Xata memory sub-nodes. Change the description to a hint (including for Window Buffer Memory) to make it clearer what the paramater does.

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/AI-229/add-hint-to-memory-nodes-to-explain-what-the-context-window-setting

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jul 26, 2024
@jeanpaul jeanpaul mentioned this pull request Jul 26, 2024
Merged
burivuhster
burivuhster requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@burivuhster burivuhster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the version for Memory Redis, and feel free to discard my first comment if you disagree :)

@jeanpaul
Copy link
Contributor Author

jeanpaul commented Aug 5, 2024

Please check the version for Memory Redis, and feel free to discard my first comment if you disagree :)

Fixed both! Thanks for checking

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

✅ All Cypress E2E specs passed

@cypress Cypress
Copy link

cypress bot commented Aug 6, 2024


Test summary

389 • 0 • 0 • 0 • Flakiness 0

Run details
Project n8n
Status Passed
Commit d97a036
Started Aug 6, 2024 8:23 AM
Ended Aug 6, 2024 8:28 AM
Duration 04:47 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@jeanpaul jeanpaul merged commit e3edeaa into master Aug 6, 2024
26 of 27 checks passed
@jeanpaul jeanpaul deleted the ai-229-add-hint-to-memory-nodes-to-explain-what-the-context-window branch August 6, 2024 08:42
MiloradFilipovic added a commit that referenced this pull request Aug 6, 2024
@MiloradFilipovic
Merge branch 'master' into ask-assistant
9e641ed 
* master:
  docs(Slack Node): Get user operation typo fix in ui (#10307)
  fix(core): Ensure OAuth token data is not stubbed in source control (#10302)
  feat(Postgres Chat Memory, Redis Chat Memory, Xata): Add support for context window length (#10203)
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Merged
@janober
Copy link
Member

janober commented Aug 7, 2024

Got released with n8n@1.54.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burivuhster burivuhster burivuhster approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanpaul @janober @burivuhster