Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Use type-safe event emitters (no-changelog) #10234

Merged
merged 6 commits into from
Jul 30, 2024
Merged

refactor(core): Use type-safe event emitters (no-changelog) #10234

merged 6 commits into from
Jul 30, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jul 29, 2024

Summary

This PR updates all EventEmitters in cli (except MessageEventBus) to be type-safe.

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 29, 2024
@netroy netroy requested a review from ivov July 29, 2024 17:46
ivov
ivov reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

packages/cli/src/TypedEmitter.ts Outdated Show resolved Hide resolved
packages/cli/src/concurrency/concurrency-queue.ts Outdated Show resolved Hide resolved
packages/cli/src/services/workflow-statistics.service.ts Show resolved Hide resolved
packages/cli/src/TypedEmitter.ts Outdated Show resolved Hide resolved
@netroy netroy requested a review from ivov July 30, 2024 10:03
ivov
ivov approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all we need is a lint rule forbidding extends EventEmitter except on TypedEmitter :)

@cypress Cypress
Copy link

cypress bot commented Jul 30, 2024


Test summary

389 • 0 • 0 • 0 • Flakiness 0

Run details
Project n8n
Status Passed
Commit 48210a1
Started Jul 30, 2024 11:10 AM
Ended Jul 30, 2024 11:14 AM
Duration 04:35 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 1fca3af into master Jul 30, 2024
30 checks passed
@netroy netroy deleted the typed-emitter branch July 30, 2024 11:23
cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
@netroy @cstuncsik
refactor(core): Use type-safe event emitters (no-changelog) (#10234)
c80073b
@ivov ivov mentioned this pull request Jul 31, 2024
Merged
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
@netroy @cstuncsik
refactor(core): Use type-safe event emitters (no-changelog) (#10234)
bdf0ec5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @ivov