refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) #10280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Aug 2, 2024
Comment on lines
+125
to
+127
| this.eventService.on('workflow-post-execute', async (event) => { | ||
| await this.workflowPostExecute(event); | ||
| }); |
There was a problem hiding this comment.
considering how frequently this pattern is repeated in this file, and likely will be repeated in other services as we start using more EventEmitters, I wonder if it makes sense to create a utility function to pass a map of eventName to handlerName, and then set these all up in there instead.
There was a problem hiding this comment.
Planning to do a cleanup of the relays before continuing with the remainder of internal hooks, I'll add this in.
| @@ -3,7 +3,6 @@ import { Push } from '@/push'; | |||
| import { jsonStringify, sleep } from 'n8n-workflow'; | |||
| import { ExecutionRepository } from '@db/repositories/execution.repository'; | |||
| import { getWorkflowHooksMain } from '@/WorkflowExecuteAdditionalData'; // @TODO: Dependency cycle | |||
There was a problem hiding this comment.
is this still a Dependency cycle?
There was a problem hiding this comment.
Unfortunately yes, but pretty small:
ExecutionRecoveryService→ Dependency cycle via@/eventbus/MessageEventBus/MessageEventBus:73MessageEventBus→ Dependency cycle via@/WorkflowExecuteAdditionalData:5
n8n-assistant
bot
added
core
ivov
deleted the
decouple-post-workflow-execute-event-from-internal-hooks-round-2
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 2, 2024
* master: refactor(core): Clean up event relays (no-changelog) (#10284) fix(editor): Fix execution retry button (#10275) feat(core): Show sub-node error on the logs pane. Open logs pane on sub-node error (#10248) refactor(core): Move instanceRole to InstanceSettings (no-changelog) (#10242) feat(core): Allow filtering executions and users by project in Public API (#10250) fix(core): Make execution and its data creation atomic (#10276) refactor(core): Mark schema env vars used by cloud hooks (no-changelog) (#10283) ci: Fix DB tests (no-changelog) (#10282) feat(core): Support create, delete, edit role for users in Public API (#10279) refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) (#10280) feat(core): Allow transferring credentials in Public API (#10259) feat(core): Support create, read, update, delete projects in Public API (#10269) ci: Introduce lint rule `no-type-unsafe-event-emitter` (no-changelog) (#10254) fix(core): Surface enterprise trial error message (#10267) fix(editor): Enable moving resources only if team projects are available by the license (#10271) fix(core): Upgrade tournament to address some XSS vulnerabilities (#10277) # Conflicts: # packages/cli/src/Server.ts
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #10232