fix(Calendly Trigger Node): Fix issue with webhook url matching #10378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffcom
changed the title
n8n-assistant
bot
added
community
Joffcom
approved these changes
Aug 20, 2024
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The webhook matching logic in
checkExistswas wrong - so it was matching existing Calendly webhooks to new workflows.Note: the same bug probably exists in the v1 implementation of Calendly node (for the
authenticationType === 'apiKey'variant). I'm not fixing that because I don't have a way to manually test it (Calendly no longer allows generating the v1 api key, it only generates the new access tokens).Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)