-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Simplify Redis client types (no-changelog) #10397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👏 Couple suggestions regarding naming things 😇
@@ -0,0 +1,19 @@ | |||
export type RedisClient = n8nRedisClient | BullRedisClient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the redis client type (or name?), not the client itself. Maybe we should rename this to RedisClientType
and N8nRedisClientType
and BullRedisClientType
(or *Name
?)
* - `publisher(n8n)` to send messages into scaling mode communication channels | ||
* - `cache(n8n)` for caching operations (variables, resource ownership, etc.) | ||
*/ | ||
type n8nRedisClient = 'subscriber(n8n)' | 'publisher(n8n)' | 'cache(n8n)'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS types should start with a capital letter, even if it's for a name that is normally written with a lowercase letter
/** | ||
* Redis client used internally by Bull. Suffixed with `(bull)` at `ScalingService.setupQueue`. | ||
* | ||
* - `subscriber(bull)` for event listening | ||
* - `client(bull)` for general queue operations | ||
* - `bclient(bull)` for blocking operations when processing jobs | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely documentation ❤️
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
✅ All Cypress E2E specs passed |
* master: (22 commits) refactor(editor): Type node view event bus (no-changelog) (#10396) refactor: Update to license SDK v2.13.1 to address dependency updates (#10422) refactor(core): Simplify Redis client types (no-changelog) (#10397) fix: Project Viewer always seeing a connection error when testing credentials (#10417) fix(editor): Fix incorrect node type version selection on new canvas (no-changelog) (#10412) fix(core): Fix payload property in `workflow-post-execute` event (#10413) fix: Require mfa code to change email (#10354) ci: Remove hard-coded package version in unit tests (no-changelog) (#10414) refactor(editor): Remove deleted event name from UI (#10402) 🚀 Release 1.55.0 (#10411) fix: Add better error handling for chat errors (#10408) ci: Trigger Docker releases on tag creation instead of release publishing (no-changelog) (#10409) fix(AI Agent Node): Fix issues with some tools not populating (#10406) feat(AI Transform Node): Telemetry (no-changelog) (#10398) feat(AI Transform Node): New node (#10405) feat: Add Ask assistant behind feature flag (#9995) refactor(editor): Use form event bus everywhere (no-changelog) (#10394) fix: Remove node AI Transform node (no-changelog) (#10400) fix(editor): Remove `@n8n/permissions` from `n8n-workflow` (no-changelog) (#10399) refactor(core): Make new configs consistent (no-changelog) (#10393) ...
Got released with |
client
,bclient
,consumer
,producer
,list-sender
,list-received
Context: https://n8nio.slack.com/archives/C069HS026UF/p1723618011118889